Re: AD review of draft-ietf-ips-iwarp-da

On Oct 19, 2006, at 4:34, Mallikarjun C. wrote:
>>   Has idnits (unused references, tabs, non-ASCII characters, etc.)  
>> and
>
> Now fixed (most of them).  I just didn't know what to do about
> non-ASCII character complaints - idnits is flagging every hyphen as  
> a non-ASCII
> character for some reason....

I'm not sure what template you use, but the easy answer is to  
manually edit the ASCII version in a text editor to replace these.

Also, there are some idnits other than about non-ASCII characters,  
please fix these, too: http://tools.ietf.org/wg/ips/draft-ietf-ips- 
iwarp-da/draft-ietf-ips-iwarp-da-04.nits.txt

>>   Document talks about the "Datmover protocol" as a wire protocol in
>
> David responded to this.  Just to make it very clear, I tweaked the  
> Abstract to say the following:
> ".....While DA defines the architectural functions required of the  
> class of Datamover protocols, it does not define any specific  
> Datamover protocols.  Each such Datamover protocol, to be defined  
> in a separate document, provides a reliable transport for all iSCSI  
> PDUs, but actually....."
> Hope that makes it clearer.

It does, thanks.

>> Section 9.2, paragraph 4:
>>>         A target iSCSI layer being notified of the arrival of TCP
>>>         RESET is an example of when the Connection_Terminate_Notify
>>>         Operational Primitive is invoked.
>>
>>   RDMAP RESET? TCP events should be hidden.
>
> True, the sentence can be misleading for it is too terse.  I  
> rephrased it to:
> A target iSCSI layer being notified of an ungraceful connection  
> termination by the Datamover layer when the underlying Transport  
> Connection is torn down due to receiving a  TCP RESET is one  
> example when the Connection_Terminate_Notify Operational Primitive  
> is invoked.

I'd suggest to rephrase this to make it clearer that there may be non- 
TCP Transport Connections:

A target iSCSI layer being notified of an ungraceful connection  
termination by the Datamover layer when the underlying Transport  
Connection is torn down. Such a Connection_Terminate_Notify  
Operational Primitive may be triggered, for example, by a TCP RESET  
in cases where the underlying Transport Connection uses TCP.

>> Section 16.1, paragraph 1:
>>>         This section discusses the specific considerations for RDMA-
>>>         based and RDDP-based Datamover protocols.
>>
>>   Shouldn't this section move to the iSER draft?
>
> If it's okay, I'd prefer to leave this section in the DA draft,  
> because
> the text is too DA-ish to belong to iSER draft.

That's actually why I thought it might make sense to move it.  
Currently, nothing in the iSER draft makes it clear that iSER is an  
instantiation of the Datamover architecture. The first mention of  
Datamover in iSER - other than in the terminology section - is buried  
in a bullet in section 2.2. This should be much more prominently stated.

Lars
-- 
Lars Eggert                                     NEC Network Laboratories

_______________________________________________
Ips mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/ips