[manet] Gunter Van de Velde's No Objection on draft-ietf-man et-dlep-credit-flow-control-17: (with COMMENT)

Gunter Van de Velde has entered the following ballot position for
draft-ietf-manet-dlep-credit-flow-control-17: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-manet-dlep-credit-flow-control/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# Gunter Van de Velde, RTG AD, comments for
draft-ietf-manet-dlep-credit-flow-control-17

# The line numbers used are rendered from IETF idnits tool:
https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-manet-dlep-credit-flow-control-17.txt

# Many thanks to Dhruv Dhody  for the RTGDIR review, and the follow up.

# Detailed Review
# ===============

400        Length:
401           16
402
403           Per [RFC8175] Length is the number of octets in the Data Item.  It
404           MUST be equal to sixteen (16).

GV> This field seems slightly underspecified. Maybe point out that the Length
is set in multiples of bytes, not bits. GV> What must happen if the length is
not set to value '16'? ignore? send a trap? reset the process? Please advice

496        Length:
497           2
498
499           Per [RFC8175] Length is the number of octets in the Data Item.  It
500           MUST be equal to two (2).

GV> similar observation as above.

Kind Regards,
Gunter Van de Velde
Routing Area Director



_______________________________________________
manet mailing list -- [email protected]
To unsubscribe send an email to [email protected]