Re: Fwd: New Version Notification for draft-ietf-mmusic-rfc4566bis-19.txt

Hi Ali,

On 6/16/17 6:32 PM, Ali C. Begen wrote:
> Hi everyone
> 
> There have been some comments on and off the list regarding the 4566bis 
> draft and with this update, I am hoping that I made all the changed 
> asked for. There were a few errors that were taken care of, some ABNF 
> syntax has been improved, references have been updated, etc.
> 
> https://www.ietf.org/rfcdiff?url1=draft-ietf-mmusic-rfc4566bis-18&url2=draft-ietf-mmusic-rfc4566bis-19
> 
> Please check whether you have outstanding issues or not. I saw that the 
> chairs updated the milestone for this draft, and from my perspective, 
> the draft is ready to go to WGLC.

I like the change to the grammar that moves the notation for 
optionality/repetition of individual fields from the definition of those 
fields to the overall definition of the session-description:

    session-description = proto-version
                          origin-field
                          session-name-field
                          [information-field]
                          [uri-field]
                          *email-fields
                          *phone-fields
                          [connection-field]
                          *bandwidth-fields
                          1*time-fields
                          [key-field]
                          *attribute-fields
                          *media-descriptions

However, this change induced a bug in the definition of media-descriptions:

    media-descriptions =  media-field
                          information-field
                          *connection-field
                          bandwidth-fields
                          key-field
                          attribute-fields

This needs the same changes made to session-description. So this needs 
to be changed to:

    media-descriptions =  media-field
                          [information-field]
                          *connection-field
                          *bandwidth-fields
                          [key-field]
                          *attribute-fields

Also this change does result in some very odd naming, where the names of 
some fields are plural but now ought to be singular. These ought to be 
fixed. Specifically:

email-fields => email-field
phone-fields => phone-field
bandwidth-fields => bandwidth-field
time-fields => time-field
attribute-fields => attribute-field
media-descriptions => media-description

Otherwise the new version seems good to me.

	Thanks,
	Paul