Re: [PATCH 1/2] ACPI/APMT: use platform_device_set_fwnode()

On Tue, Jul 28, 2026 at 04:07:16PM +0200, Bartosz Golaszewski wrote:
> Platform devices using the split approach of calling
> platform_device_alloc() and platform_device_add() must not assign the
> firmware nodes manually but use the provided
> platform_device_set_fwnode() function which additionally makes sure we
> track the reference count of the firmware node correctly.
> 
> Replace the manual assignment of the firmware node with a call to
> platform_device_set_fwnode().
> 

I don't see platform_device_set_fwnode() in the upstream tree, is it in
-next ? I didn't see -next tag as well.

> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
>  drivers/acpi/arm64/apmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c
> index bb010f6164e528acd802f65afd80d65a57f5844f..c927e4f08ec2c98137d4e3c64ec1709d672ad9a2 100644
> --- a/drivers/acpi/arm64/apmt.c
> +++ b/drivers/acpi/arm64/apmt.c
> @@ -99,7 +99,7 @@ static int __init apmt_add_platform_device(struct acpi_apmt_node *node,
>  	if (ret)
>  		goto dev_put;
>  
> -	pdev->dev.fwnode = fwnode;
> +	platform_device_set_fwnode(pdev, fwnode);
>  

Assuming platform_device_set_fwnode() does what is needed,

Acked-by: Sudeep Holla <[email protected]>

-- 
Regards,
Sudeep