Re: [ACPI-sppt] ACPI patch

Luca Capello <[email protected]> Thu, 25 Sep 2003 19:30:03 +0100

Newsgroups	gmane.linux.acpi.support
Message-ID	<[email protected]>

Hello Micha, thank you for your support.

on 25/09/2003 16.26, Micha Feigin wrote:
> There is a bug in the config file. I raised that point some time ago.
> iirc correctly it was fixed but don't remember since what kernel
> version.
> I think 2.4.22 is quite stable, but if you prefer 2.4.21 you will need
> to change
> drivers/acpi/Config.in
> 
> There is something about CONFIG_ACPI_HT_ONLY enabled dependent on
> CONIFG_LOCAL_APIC or something close.
> If you want the most generic option and an else clause to that if:
> 
> else
>       define_bool CONFIG_ACPI_HT_ONLY n
> fi
> 
> this should solve you problem (you can email me the file privately if
> you have problems since I don't have a copy to fix for you.
I fixed it copying the 'Config.in' from kernel 2.4.22 patche ACPI 
20030916. As I'd like to make an ASUS Centrino patch, I attached the new 
'Config.in', so please could you tell me if all is ok? I mean, I tried 
it and it works, but as you can see, I substituted the call for 
CONFIG_ACPI_HT_ONLY (as on 2.4.21) with that for CONFIG_SMP (as on 
2.4.22). If all is ok, I'll make the patch.

>>I'm trying the new 2.4.22, but when I tried it one month ago I got some 
>>problem and as my 2.4.21 is more tested and it works perfectly, I stayed 
>>w/ it.
I remembered why I continued using 2.4.21: I installed the patched 
2.4.22 and all went ok, but at reboot, I can't use not my keyboard 
neither my touchpad and I didn't change anything in the .config... So, I 
came back to 2.4.21 with the patch from Micha ;-)

Thank you and, again, many thanks to Robert, now I've a Linux complete 
working ASUS M3N :-)

Gismo / Luca

Config.in (text/plain, 3 KB)

#
# ACPI Configuration
#

if [ "$CONFIG_X86" = "y" ]; then

  mainmenu_option next_comment
  comment 'ACPI Support'
  bool         'ACPI Support' CONFIG_ACPI
  if [ "$CONFIG_ACPI" = "y" ]; then
#    if [ "$CONFIG_X86_LOCAL_APIC" = "y" ]; then
#      bool         'CPU Enumeration Only' CONFIG_ACPI_HT_ONLY
    if [ "$CONFIG_SMP" = "y" ]; then
      bool         'CPU Enumeration Only' CONFIG_ACPI_HT_ONLY
    else
      define_bool CONFIG_ACPI_HT_ONLY n
    fi

    if [ "$CONFIG_ACPI_HT_ONLY" = "n" ]; then
      define_bool CONFIG_ACPI_BOOT		y
      define_bool CONFIG_ACPI_BUS		y
      define_bool CONFIG_ACPI_INTERPRETER	y
      define_bool CONFIG_ACPI_EC		y
      define_bool CONFIG_ACPI_POWER		y
      if [ "$CONFIG_PCI" = "y" ]; then
        define_bool CONFIG_ACPI_PCI		y
      fi
      define_bool CONFIG_ACPI_SLEEP		y
      define_bool CONFIG_ACPI_SYSTEM		y
      tristate     '  AC Adapter'	CONFIG_ACPI_AC
      tristate     '  Battery'		CONFIG_ACPI_BATTERY
      tristate     '  Button'		CONFIG_ACPI_BUTTON
      tristate     '  Fan'		CONFIG_ACPI_FAN
      tristate     '  Processor'	CONFIG_ACPI_PROCESSOR
      dep_tristate '  Thermal Zone' 	CONFIG_ACPI_THERMAL $CONFIG_ACPI_PROCESSOR
      if [ "$CONFIG_NUMA" = "y" ]; then
        dep_bool       '  NUMA support'     CONFIG_ACPI_NUMA $CONFIG_NUMA
      fi
      tristate     '  ASUS Laptop Extras'  CONFIG_ACPI_ASUS
      tristate     '  Toshiba Laptop Extras'	CONFIG_ACPI_TOSHIBA
      bool         '  Debug Statements'	CONFIG_ACPI_DEBUG
    fi
  fi

  endmenu

fi


if [ "$CONFIG_IA64" = "y" ]; then

  if [ "$CONFIG_IA64_SGI_SN" = "y" ]; then
    mainmenu_option next_comment
    comment 'ACPI Support'
    define_bool CONFIG_ACPI		y
    define_bool CONFIG_ACPI_EFI		y
    define_bool CONFIG_ACPI_BOOT	y
    define_bool CONFIG_ACPI_BUS		n
    define_bool CONFIG_ACPI_INTERPRETER n
    define_bool CONFIG_ACPI_PCI		n
    define_bool CONFIG_ACPI_POWER 	n
    define_bool CONFIG_ACPI_SYSTEM 	n
    define_bool CONFIG_ACPI_BUTTON	n
    define_bool CONFIG_ACPI_FAN		n
    define_bool CONFIG_ACPI_PROCESSOR	n
    define_bool CONFIG_ACPI_THERMAL	n
    define_bool CONFIG_ACPI_NUMA	y
    endmenu
  fi

  if [ "$CONFIG_IA64_HP_SIM" = "n" ]; then
    mainmenu_option next_comment
    comment 'ACPI Support'
    if [ "$CONFIG_PCI" = "y" ]; then
      define_bool CONFIG_ACPI_PCI 	y
    fi
    define_bool CONFIG_ACPI		y
    define_bool CONFIG_ACPI_EFI		y
    define_bool CONFIG_ACPI_BOOT	y
    define_bool CONFIG_ACPI_BUS		y
    define_bool CONFIG_ACPI_INTERPRETER y
    define_bool CONFIG_ACPI_POWER 	y
    define_bool CONFIG_ACPI_SYSTEM 	y
    tristate     '  Button'		CONFIG_ACPI_BUTTON
    tristate     '  Fan'		CONFIG_ACPI_FAN
    tristate     '  Processor'		CONFIG_ACPI_PROCESSOR
    dep_tristate '  Thermal Zone'       CONFIG_ACPI_THERMAL $CONFIG_ACPI_PROCESSOR
    if [ "$CONFIG_NUMA" = "y" ]; then
      dep_bool       '  NUMA support'       CONFIG_ACPI_NUMA $CONFIG_NUMA
    fi
    bool         '  Debug Statements' 	CONFIG_ACPI_DEBUG
    endmenu
  fi

fi