Re: [PATCH] networking: ntpd.c: fix NULL pointer dereference in recv_and_process_client_pkt

Charles Mirabile via busybox <[email protected]> Sun, 17 May 2026 11:05:01 -0400
Newsgroups gmane.linux.busybox
Message-ID <CABe3_aFCnsXDqgZvED=UoBh9yJjLya4D7q59x6RA52TYWB436g@mail.gmail.com>
SGnigJQKCk9uIFN1biwgTWF5IDE3LCAyMDI2IGF0IDEwOjIw4oCvQU0gQW50b24gTW9yeWFrb3Yg
dmlhIGJ1c3lib3gKPGJ1c3lib3hAYnVzeWJveC5uZXQ+IHdyb3RlOgo+Cj4gU3RhdGljIGFuYWx5
c2lzIChTQVNUKSByZXBvcnRlZCBhIHBvdGVudGlhbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2U6
Cj4KPiAgIG50cGQuYzoyMDg4OiBmcm9tID0geHphbGxvYyh0by0+bGVuKTsKPiAgIFdhcm5pbmc6
IFBvaW50ZXIgcmV0dXJuZWQgZnJvbSBnZXRfc29ja19sc2EoKSBtYXkgYmUgTlVMTCBhbmQgaXMK
PiAgIGRlcmVmZXJlbmNlZCBhdCBudHBkLmM6MjA4OC4KPgo+IFRoZSBmdW5jdGlvbiBnZXRfc29j
a19sc2EoKSAobGliYmIveGNvbm5lY3QuYykgZG9lcyBub3QgaGF2ZSB0aGUgJ3gnCj4gcHJlZml4
LCBtZWFuaW5nIGl0IGNhbiByZXR1cm4gTlVMTCBvbiBlcnJvciAoZS5nLiwgaWYgZ2V0c29ja25h
bWUoKQo+IGZhaWxzIGR1ZSB0byBpbnZhbGlkIHNvY2tldCwgcmVzb3VyY2UgZXhoYXVzdGlvbiwg
b3IgY29udGFpbmVyCj4gcmVzdHJpY3Rpb25zKS4gVGhlIGNvZGUgZGlkIG5vdCBjaGVjayB0aGUg
cmV0dXJuIHZhbHVlIGJlZm9yZQo+IGFjY2Vzc2luZyB0by0+bGVuLCB3aGljaCBjb3VsZCBsZWFk
IHRvIGEgY3Jhc2guCj4KPiBGaXg6IGFkZCBleHBsaWNpdCBOVUxMIGNoZWNrIGFmdGVyIGdldF9z
b2NrX2xzYSgpIGNhbGwuCj4gSWYgdG8gaXMgTlVMTCwgcmVwb3J0IGVycm9yIGFuZCB0ZXJtaW5h
dGUgKGNvbnNpc3RlbnQgd2l0aCBvdGhlcgo+IGZhdGFsIGVycm9yIGhhbmRsaW5nIGluIG50cGQg
c2VydmVyIHBhdGgpLgoKVGhpcyBjaGFuZ2UgaXMgbm90IGluY29ycmVjdCBwZXIgc2UsIGJ1dCBp
dCBpcyBvdmVybHkgZGVmZW5zaXZlIEkKdGhpbmsuIExvb2tpbmcgaW50byB0aGUgYWN0dWFsIGNv
ZGUgZm9yIGBnZXRfc29ja19sc2FgIHdlIGNhbiBzZWUgdGhhdAppdCBpcyBqdXN0IGEgd3JhcHBl
ciBhcm91bmQgYGdldF9sc2FgIGZvciBgZ2V0c29ja25hbWVgLiBUaGUgb25seSB0aW1lCml0IGNh
biByZXR1cm4gbnVsbCBpcyBpZiB0aGUgY2FsbCB0aGUgYGdldHNvY2tuYW1lYCBmYWlscyAodGhl
IGJ1ZmZlcgppdCByZXR1cm5zIGlzIGFsbG9jYXRlZCB3aXRoIGB4emFsbG9jYCBzbyBtdXN0IGJl
IG5vbm51bGwpLiBSZWFkaW5nCnRoZSBtYW4gcGFnZSBmb3IgYGdldHNvY2tuYW1lYCB0aGUgb25s
eSB0aW1lIGl0IHJlYWxseSBjYW4gZmFpbCBpcyBkdWUKdG8gYSBwcm9ncmFtbWVyIGVycm9yIHdo
ZW4gY2FsbGluZyB0aGUgZnVuY3Rpb24gKGUuZy4gcGFzc2VkIGFuCmludmFsaWQgcG9pbnRlciBv
ciBhIGZkIHRoYXQgaXMgbm90IGEgc29ja2V0KS4KCkkgZG9uJ3Qgc2VlIGFueSB3YXkgdGhhdCB0
aG9zZSBlcnJvcnMgY291bGQgYmUgdHJpZ2dlcmVkIGR1ZSB0byBhCnJ1bnRpbWUgY29uZGl0aW9u
IHVubGVzcyB0aGVyZSB3YXMgc29tZSBvdGhlciBsb2dpYyBidWcgaW4gdGhlCmFwcGxpY2F0aW9u
IHRoYXQgbGVhZCB0byBhbiBpbnZhbGlkIGNhbGwgdG8gYGdldF9zb2NrX2xzYWAuIEFzIHN1Y2gg
SQpkbyBub3QgdGhpbmsgdGhhdCBpdCBpcyB3b3J0aCBpdCB0byBibG9hdCB0aGUgYmluYXJ5IHdp
dGggdGhlIGZldwppbnN0cnVjdGlvbnMgdG8gY2hlY2sgZm9yIHNvbWV0aGluZyB0aGF0IGNhbm5v
dCBoYXBwZW4gYXNzdW1pbmcgdGhlCnJlc3Qgb2YgdGhlIGxvZ2ljIGlzIHNvdW5kLiBDYW4geW91
IGFjdHVhbGx5IHRyaWdnZXIgdGhlIG51bGwKZGVyZWZlcmVuY2UgaW4gcHJhY3RpY2Ugb3IgaXMg
dGhpcyBzZWN1cml0eSB0aGVhdGVyPwoKSWYgaXQgYWN0dWFsbHkgd2VyZSBwb3NzaWJsZSB0byBn
ZXQgbnVsbCB0aGUgYmV0dGVyIGZpeCB3b3VsZCBiZSB0bwpjb3JyZWN0IHdoYXRldmVyIGVsc2Ug
d2VudCB3cm9uZyBpbiB0aGUgYXBwbGljYXRpb24gbG9naWMgYmVmb3JlIHRoaXMKY2FsbCB0byBw
cmV2ZW50IGl0IGZyb20gcmV0dXJuaW5nIG51bGwsIG5vdCBkZXRlY3QgaXQgYWZ0ZXJ3YXJkcyBh
bmQKcGFuaWMuCgpCZXN04oCUQ2hhcmxpZQoKPgo+IFNpZ25lZC1vZmYtYnk6IEFudG9uIE1vcnlh
a292IDxhbnQudi5tb3J5YWtvdkBnbWFpbC5jb20+Cj4gLS0tCj4gIG5ldHdvcmtpbmcvbnRwZC5j
IHwgMiArKwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0
IGEvbmV0d29ya2luZy9udHBkLmMgYi9uZXR3b3JraW5nL250cGQuYwo+IGluZGV4IDU5NTAwMGIx
MS4uOTg5ZjcxNzFlIDEwMDY0NAo+IC0tLSBhL25ldHdvcmtpbmcvbnRwZC5jCj4gKysrIGIvbmV0
d29ya2luZy9udHBkLmMKPiBAQCAtMjA4Niw2ICsyMDg2LDggQEAgcmVjdl9hbmRfcHJvY2Vzc19j
bGllbnRfcGt0KHZvaWQgLyppbnQgZmQqLykKPiAgICAgICAgIGxfZml4ZWRwdF90ICAgICAgcXVl
cnlfeG10dGltZTsKPgo+ICAgICAgICAgdG8gPSBnZXRfc29ja19sc2EoR19saXN0ZW5fZmQpOwo+
ICsgICAgICAgaWYgKCF0bykKPiArICAgICAgIGJiX3NpbXBsZV9wZXJyb3JfbXNnX2FuZF9kaWUo
ImdldF9zb2NrX2xzYSIpOwo+ICAgICAgICAgZnJvbSA9IHh6YWxsb2ModG8tPmxlbik7Cj4KPiAg
ICAgICAgIHNpemUgPSByZWN2X2Zyb21fdG8oR19saXN0ZW5fZmQsICZtc2csIHNpemVvZihtc2cp
LCBNU0dfRE9OVFdBSVQsIGZyb20sICZ0by0+dS5zYSwgdG8tPmxlbik7Cj4gLS0KPiAyLjM5LjIK
Pgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYnVz
eWJveCBtYWlsaW5nIGxpc3QKPiBidXN5Ym94QGJ1c3lib3gubmV0Cj4gaHR0cHM6Ly9saXN0cy5i
dXN5Ym94Lm5ldC9tYWlsbWFuL2xpc3RpbmZvL2J1c3lib3gKPgoKX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYnVzeWJveCBtYWlsaW5nIGxpc3QKYnVzeWJv
eEBidXN5Ym94Lm5ldApodHRwczovL2xpc3RzLmJ1c3lib3gubmV0L21haWxtYW4vbGlzdGluZm8v
YnVzeWJveAo=