Re: [patch 3/21] openmosix/openmosix-__kcom_task_find-spinlocks.patch

Vincent Hanquez wrote:
> On Wed, Nov 01, 2006 at 05:10:35AM +0100, Florian Delizy wrote:
>   
>> +	read_lock(&tasklist_lock);
>>  	p = find_task_by_pid(pid);
>> -	// read_unlock(&tasklist_lock);
>> +	 read_unlock(&tasklist_lock);
>>     
>
> wave ... indentation broken.
>   

Hum, I'll look at that
>   
>> +                read_lock( &kcom_nodes_lock );
>>     
>
>   
> it's no kernel style to put spaces after '(' and before ')'
>
> etc...
>
> the same hold for a lots of this patches ... consistant codingstyle is
> important.
>   
Hum, just checked the CodingStyle, I didn't notice that earlier, I'll 
try to change the coding style as well ok
Do you want me to re-submit all patches with proper coding style ?


BTW, there are now a lot of patches, I guess the best way to handle it 
is to let me finish fixing the migration, then merge them all ... review 
one by one take time, and you don't seem to have that time ...

what do you think of it ?


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642