Re: [patch 8/21] openmosix/migration_verbose_traces.patch

On Wed, Nov 01, 2006 at 05:11:25AM +0100, Florian Delizy wrote:
> Add some interesting traces using OMDEBUG* macros

> Index: linux/hpc/migsend.c
> ===================================================================
> --- linux.orig/hpc/migsend.c	2006-10-23 19:28:47.000000000 +0200
> +++ linux/hpc/migsend.c	2006-10-26 16:20:35.000000000 +0200
> @@ -1,6 +1,7 @@
>  /*
>   *	Copyright (C) 2002-2004 Moshe Bar <moshe-ay74M1d3r6RWk0Htik3J/[email protected]>
>   *	Copyright (C) 2005-2006 Vincent Hanquez <vincent-mTI/[email protected]>
> + *	Copyright (C) 2006 Florian Delizy <[email protected]>
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published
> @@ -14,6 +15,7 @@
>   * Original Mosix code Copyright (C) Amnon Barak, Amnon Shiloh
>   *
>   * Changes for 2.6 by Vincent Hanquez and Alexander Nyberg
> + * - kcomd thread by Matt Dew and Florian Delizy
>   *
>   */
>  
> @@ -45,6 +47,7 @@
>  	struct omp_mig_handshake hshake, hshake_recv;
>  	int error;
>  
> +	OMDEBUG_MIG( 2, "%s sending process %d\n", __FUNCTION__, p->pid );

all of those looks really awful.
hide the __FUNCTION__ directly in a macro or something similar.

-- 
Vincent Hanquez

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642