Re: [patch 7/21] openmosix/mig_do_receive_cleanup.patch mig_do_receive cleanup

Vincent Hanquez wrote:
> On Wed, Nov 01, 2006 at 05:11:03AM +0100, Florian Delizy wrote:
>   
>> +	protocol_sleep:
>> +		write_unlock( &mytsk->spinlock );
>> +		schedule();
>> +		set_current_state(TASK_INTERRUPTIBLE);
>> +		write_lock( &mytsk->spinlock );
>>     
>
> schedule and then set_current_state ? looks bogus to me.
>   
OK, fixed
>   
>> @@ -575,8 +588,9 @@
>>   * Description:
>>   *    This is the newly created process.
>>   **/
>> -KCOMD_NSTATIC NORET_TYPE int mig_handle_migration(pid_t *pid)
>> +KCOMD_NSTATIC int mig_handle_migration(void *param)
>>  {
>> +	pid_t *pid = (pid_t *) param;
>>  	task_t *p = current;
>>  	int error;
>>  
>> @@ -621,5 +635,6 @@
>>  	OMBUG("failed\n");
>>  	do_exit(SIGKILL);
>>  	/*NOTREACHED*/
>> +	return 0;
>>     
>
> that's bogus. NORET_TYPE should be specified, and no return code.
>
>   
OK, fixed

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642