Re: [patch 1/5] openmosix/fix-__pkt_read-data-init.patch

Vincent Hanquez wrote:
> On Fri, Dec 22, 2006 at 11:46:16PM +0100, Florian Delizy wrote:
>   
>>  	// read in any data
>> +        (*recv_kcom_pkt)->data = NULL;
>>     
>
> tabs, not spaces
>   
Well *spaces* not *tabs ...
>   
>> -	if (pkt->data) kfree(pkt->data);
>> +	if (pkt->len && pkt->data) kfree(pkt->data);
>>  
>>  	kmem_cache_free(kcom_pkt_cachep, pkt);
>>  }
>>     
>
> remove pkt->data from the test. I don't even see the need for pkt->len
> either. it should only be "kfree(pkt->data);"
>
>   
Well, you're right, I'll do that, (it was needed before since pkt->data 
used to be uninitialized

BTW,

Happy new year :)


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV