Re: [patch 2/5] openmosix/pkt-header-end-mark.patch

Vincent Hanquez wrote:
> On Fri, Dec 22, 2006 at 11:46:36PM +0100, Florian Delizy wrote:
>   
>> This patch adds a end marker to the kcom_pkt struct so that useless
>> fields are not anymore sent to the network. That way, the kcom_pkt
>> struct can be extended to offer precious fields without cost.
>>     
>
> This is hideous. you better duplicate the structure to what you need and
> having *explicit* operations to convert from and to, the sent-structure.
>
> (also those 2 extras fields has absoluty no cost on a typical network)
>
>   
I don't agree on both points, ... I don't think this is 'hideous' (it's 
the kernel way ...) and 2 extra fields can have a cost on high 
communication duty ... Moreover they really *are*  useless to send.

About the pkt struct split, this is a solution, I'll consider it

Cheers

Florian Delizy

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV