Re: RPVPSOP_END typo bug

Hi Roger,

If you are talking about "ret" being a typo.  You are right for code correctness it should probably be "_ret".  However, considering that all callers pass in "ret", functionally,  comparing "ret" in the switch statement should still yield the same result.

laura

-----Original Message-----
From: Roger Tsang [mailto:[email protected]]
Sent: Friday, March 14, 2008 3:49 PM
To: ssic-linux-devel
Cc: Ramirez, Laura L
Subject: RPVPSOP_END typo bug

Hi,

Looks like a typo in ssi-1.9 and affects quite a lot of VPROC.

-Roger


#define RPVPSOP_END(_ret,_error,_id_string)                             \
        switch(ret) {                                                  \
                case 0:                                                 \
                        break;                                          \
                case -EREMOTE:                                          \
                        _error = -EREMOTE;                              \
                        break;                                          \
                default:                                                \
                        printk("%s: bad rpc, ret=0x%x",_id_string,_ret);\
                        _error = -EREMOTE;                              \
                        break;                                          \
        }                                                               \

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/