Bug#661109: lsb: Please include helper function for init scripts on upstart-based systems

On Tue, May 01, 2012 at 09:45:44AM +0200, Didier 'OdyX' Raboud wrote:
> Le 01.05.2012 07:42, Steve Langasek a écrit :
> > My opinion is that this is best done in the single /lib/lsb/init-functions
> > file.  The filename is an interface defined in the LSB, but there's nothing
> > in the LSB that says this interface can't provide additional shell
> > functions; and having this all in a single place simplifies the interface
> > for the Debian init scripts.  And if you've followed the discussion on
> > debian-devel, you know that there's quite a lot of interest in having
> > simpler init scripts. :)

> > If you decide not to include this patch in lsb/init-functions, then I guess
> > I'll propose a new shell include as you describe; but I really don't think
> > that's the best solution.

> That's convincing enough for me. I just committed the attached patch and
> will push it later today. I plan to upload it after the new Fancy output
> (as 4.1+Debian1) will have reached testing, along with other stuff.

> Thanks for your patch, cheers,

Great, thanks!

BTW, I'm sorry to say I've just noticed the patch I sent has a bug; the
output of 'which initctl' should be suppressed, otherwise each init script
using this function will output "/sbin/initctl" which we don't want.

So the line should be:

   if which initctl >/dev/null && initctl version | grep -q upstart

Sorry for the bug.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
[email protected]                                     [email protected]

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBT6DacVaNMPMhshM9AQj8NA/9HPHuNKBr4RG0F6eOBUUxNQMCLYPu/Mz4
gTytaJCbSEKEDBhOjZHoYTQFdZBA7hh6Sb57ZVHy1piSxEG7IZCIu0H2Hid5j2Se
hEyuhIGHQE+bKcJnmq9O0ZasNw4ejrJ0ojIcZiQmL8AoT/MVe+tU0ug81hlRLV+/
DEHit8Fw8G8526nkXUgNGIXzyU4806s0NLDEAa2AeyEjBUOcT/k/3vVySE3FQvY3
9+0pNBr2CXOfsU4MGHZ8coHMOqyOd2MHMH/UgzfutVPHkKSyuVP/Jh2E9Dt7jTiT
+VxB8GN5MZZ2klYwWyx8GCRHWPVhC0D3sCS5QRWm+wp6nkbxqQ2vOKSncK2AXPfm
xS2lkJFHpeFTOstN2pJszur29kwJxpczX3e9ohp0z9meS4LbijHXL1QdG2XRnPWL
75YjeY81slKYH18C8INtTf/wB88QhSXiOnYoYGjyz9XQkel3T3GBISMXuT5pGujj
itXCmyxECnTFp3dm5Ff+5nY3QXD9+F5Qu04myrWbn3gsI7w2V9p5kat8eKybIU23
N10cpPBGjGopg7K9HYT9uawE9FQp8A3d5CnNqsLsiRV3uCh6Ah9E241SCLW6bIX2
hZMxFiJc5t4SuJH/GU11JsNU7jwoGeMVJmKcvFrExM22F/5fj0Ree2n/YlE3K2YE
qp64UNvVuPY=
=CzI2
-----END PGP SIGNATURE-----