Bug#661109: lsb: Please include helper function for init scripts on upstart-based systems

"Didier 'OdyX' Raboud" <[email protected]> Wed, 02 May 2012 09:35:34 +0200

Newsgroups	gmane.linux.debian.devel.lsb
Organization	Debian, the Universal OS
Message-ID	<[email protected]>

Le 02.05.2012 08:55, Steve Langasek a écrit :
> BTW, I'm sorry to say I've just noticed the patch I sent has a bug; the
> output of 'which initctl' should be suppressed, otherwise each init script
> using this function will output "/sbin/initctl" which we don't want.
> 
> So the line should be:
> 
>    if which initctl >/dev/null && initctl version | grep -q upstart

Good catch. That said, wouldn't the following be more robust ?

if [ -x /sbin/initctl ] && /sbin/initctl version | /bin/grep -q upstart

In init-functions, no PATH is defined (all executables are currently
called with full paths). And only upstart ships /sbin/initctl, right?

Cheers,

OdyX

signature.asc (application/pgp-signature, 663 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQGcBAEBAgAGBQJPoOPRAAoJEIvPpx7KFjRVpa0L/3Ugcs8454oNO8+XfnWQVIub
7Eej0gzcUFXNyuDpe1SWKE6VCGyKMO7HlMo1PNorN+rkSo910c3lAz82lceKexEi
pZu2VBWoAjIUUumMEQ9vsMa0xvA0kQwtB8m6ycbsfMK4qAelHrsUb/vjNoD+Kisg
qaJqwFtSE4CLcyFySI+aJFpXVsZQBMk83+YkwDpxIgfAwiycdGskh+aQK7JQtNrL
6bdT5gVmBiPaRkIlaUK7/BmGgAg2Ccvamlz1IwSFOAXCtrpMqzA0BUAZxUGtoYsj
eAQ4uFYkFqIS4kOanf2d86+pP4/hIkV5Tb1WR4PZqYTzkJVCIR95mibB8JC/PX/w
g3j6nuF0mfJzwuPrrGRyDOM75d87/yPg4IOPpKFm5GdZvnkuJHjCpCbKRNHBYWOY
wmBayNue95BxYizUjKnO0gNVGdCwu7zx7lmdJPvFOFRPCAhCSmKN9mXZkqJHxdd1
0XkFJF9/gcYI+v8H6VcjaEfRRLeL5ctT04x13rillA==
=xSE4
-----END PGP SIGNATURE-----