Re: Xpore Autopkgtest Review ( Bug #1035276 )

On 12/29/2023 6:31 PM IST Komolehin Israel <[email protected]> wrote:
> > On Fri, 29 Dec 2023 at 1:36 PM, Nilesh Patra wrote:
> > On Fri, Dec 29, 2023 at 05:57:13PM +0530, Nilesh Patra wrote:
> >  > Hi Israel,
> >  > 
> >  > On Fri, Dec 29, 2023 at 01:01:47PM +0100, Komolehin Israel wrote:
> >  > > I worked on the Xpore package by providing autopkgtest and embedding test
> >  > > data. CI was successful.
> >  > > 
> >  > > This closes #1035276 bug.
> >  > > 
> >  > > I look forward to its review and upload.
> >  > 
> >  > I have two comments:
> >  > 
> >  > * Add in the copyright information for the test data.
> >  > * Add in a script to automate downloading of this test data in future, similar to[1]
> >  
> > > You can also look at [2][3][4] which seem more relevant.
> >  
> >  > [1]: https://salsa.debian.org/med-team/yanagiba/-/blob/master/debian/tests/get-test-data?ref_type=heads
> > > [2]: https://salsa.debian.org/med-team/dcm2niix/-/blob/debian/master/debian/tests/get-test-data?ref_type=heads
> > > [3]: https://salsa.debian.org/med-team/resfinder/-/blob/master/debian/tests/get-test-data?ref_type=heads
> > > [4]: https://salsa.debian.org/med-team/multiqc/-/blob/master/debian/tests/get-test-data?ref_type=heads
> > 
> > 
> Thanks Nilesh,
> I will check them out.

Seems like you sorted this out as communicated on matrix -- thanks!

I did a few changes -- please do look at my commits:
* The license text of cc-by-4.0 was wrong, you seemed to have copied wrong text. The para with "Attribution 4.0 International" here[1] is the actual license.
* Every upload wherein you're not in Uploaders field should start with a "* Team Upload" entry.
* Bumped the standards version
* Minor typos/adjustments

Uploaded after these changes. Thanks again!

[1]: https://creativecommons.org/licenses/by/4.0/legalcode

Best,
Nilesh