Bug#1141175: RFS: moraine/0.1.1-1 [ITP] -- snapshot backup over SSH/rsync and rclone

This is a multi-part message in MIME format.
--------------9UND7ksRQDqjLMCFlgUrYwMh
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Control: tags -1 - moreinfo

Hello Simon, hope you're having a great summer so far! Raining here in 
Sweden, so a perfect time to do some FOSS work :)

moraine 0.2.1-1 is now on mentors, and I owe you a small confession: 
when I wrote last time that all five points were done, they were done in 
my head and in my working copy, but they never made it into the package 
sitting on mentors. You were reviewing the old one. Sorry about that. 
This time I checked the uploaded source instead of trusting my own 
memory. I'm still VERY new to this, but loving every minute of 
developing this beauty!

What is actually in this upload:

- debian/changelog is a single "Initial release. (Closes: #1141131)" entry.
- debian/copyright says "Expat" instead of "MIT".
- Standards-Version is 4.7.4, and Priority and Rules-Requires-Root are gone.
- debhelper-compat is 14, plus dh-sequence-single-binary, which dh asks 
for explicitly in compat 14.
- debian/watch is the version 5 deb822 format.

Your build log was the most useful part of the review, so thank you for 
attaching it. It turned out there were two crates that are not in 
Debian, and cargo resolves both of them even though neither is ever 
compiled here:

- ksni, the system-tray icon. debian/rules now builds with 
--no-default-features --features gui, so the tray is simply left out. 
The GUI already has a #[cfg(not(feature = "tray"))] path for platforms 
without a tray, so nothing else changes.
- winresource, a Windows-only build-dependency that build.rs uses under 
#[cfg(windows)] to embed the icon into the .exe. Cargo resolves 
target-specific dependencies for every target, not just the host, so it 
broke the Linux build even though it is never built. Removed with a 
quilt patch.

It now builds cleanly with sbuild in a sid chroot, and lintian is quiet.

dget -x 
https://mentors.debian.net/debian/pool/main/m/moraine/moraine_0.2.1-1.dsc

I am still learning this as I go, so I really do appreciate you taking 
the time. Removing the moreinfo tag with this mail, and I am around if 
you spot anything else.

Best regards,
Jonaz Thern

On 7/22/26 13:39, Simon Quigley wrote:
> Hello,
>
> Thanks for the update here. It seems like you've addressed most of or 
> all of the points.
>
> Could you please remove the moreinfo tag once a new version is on Mentors?
>
> Thanks,
> Simon
>
>
> On July 17, 2026 3:58:09 PM CDT, Thern AI Solutions <[email protected]> wrote:
>
>     Hello Simon, and thanx for contacting me. First of all, sorry for
>     the late reply. 3 kids, 2 jobs (1 wich is my own business) and a
>     hours takes alot of time, and Moraine is something I enjoy working
>     on whenever I get a few hours for myself. Thank you so much for
>     taking the time to go through this in such detail. I'm still
>     fairly new to Debian packaging and learning something new with
>     every round of feedback, so this is genuinely a big help to me.
>     I've addressed all five points: 1. Changelog    Collapsed it down
>     to a single initial entry and corrected the version to 0.2.0-1 — I
>     hadn't realised a first upload should just be one "Initial
>     release" entry rather than carrying the whole history. 2.
>     Copyright / license name    Renamed the license from "MIT" to
>     "Expat" in debian/copyright. Good learn that Expat is the correct
>     name for this exact license text in Debian. 3. Standards-Version
>     and control fields    Bumped Standards-Version to 4.7.4 and
>     dropped both Rules-Requires-Root: no and Priority: optional from
>     the source stanza. 4. debhelper compat    Upgraded to
>     debhelper-compat 14. 5. Watch file    Upgraded to version 5. I
>     learned along the way that v5 is a new deb822-style format rather
>     than just a version-number bump, so I rewrote it with the
>     Version/Source/Mode/Matching-Pattern fields (still tracking the
>     git tags). All five are done in the packaging. I'll give it a
>     final lintian run in a clean unstable chroot and upload the
>     corrected 0.2.0-1 to mentors. Please let me know if there's
>     anything else I should fix — I really appreciate the guidance.
>     Thanks again, Jonaz On 7/14/26 23:18, Simon Quigley wrote:
>
>         Control: tags -1 +moreinfo Hello, Thank you for your work
>         here. A few things: - Please only keep one changelog entry,
>         the initial one, with a corrected version. The additional
>         changelog entries are not needed. - In the license file, it is
>         expected to use the license name "Expat" instead of "MIT,"
>         please fix that. - Please update Standards-Version to 4.7.4,
>         dropping Rules-Requires-Root: no and Priority: optional. -
>         Please consider upgrading to debhelper-compat 14. - Please
>         upgrade the watch file to version 5. I also can't get it to
>         build, see the attached log. If this is a Rust package, you
>         might want to include it in the debcargo-conf monorepo
>         following their docs: https://rust-team.pages.debian.net/book/
>         Please remove the moreinfo tag once you're ready for another
>         review. Feel free to CC me, if I'm available I can re-review.
>         Best regards, Simon Quigley [email protected] 
>
--------------9UND7ksRQDqjLMCFlgUrYwMh
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Control: tags -1 - moreinfo<br>
      <br>
      Hello Simon, hope you're having a great summer so far! Raining
      here in Sweden, so a perfect time to do some FOSS work :)</p>
    <p>moraine 0.2.1-1 is now on mentors, and I owe you a small
      confession: when I wrote last time that all five points were done,
      they were done in my head and in my working copy, but they never
      made it into the package sitting on mentors. You were reviewing
      the old one. Sorry about that. This time I checked the uploaded
      source instead of trusting my own memory. I'm still VERY new to
      this, but loving every minute of developing this beauty!<br>
      <br>
      What is actually in this upload:<br>
      <br>
      - debian/changelog is a single "Initial release. (Closes:
      #1141131)" entry.<br>
      - debian/copyright says "Expat" instead of "MIT".<br>
      - Standards-Version is 4.7.4, and Priority and Rules-Requires-Root
      are gone.<br>
      - debhelper-compat is 14, plus dh-sequence-single-binary, which dh
      asks for explicitly in compat 14.<br>
      - debian/watch is the version 5 deb822 format.<br>
      <br>
      Your build log was the most useful part of the review, so thank
      you for attaching it. It turned out there were two crates that are
      not in Debian, and cargo resolves both of them even though neither
      is ever compiled here:<br>
    </p>
    <p>- ksni, the system-tray icon. debian/rules now builds with
      --no-default-features --features gui, so the tray is simply left
      out. The GUI already has a #[cfg(not(feature = "tray"))] path for
      platforms without a tray, so nothing else changes.<br>
      - winresource, a Windows-only build-dependency that build.rs uses
      under #[cfg(windows)] to embed the icon into the .exe. Cargo
      resolves target-specific dependencies for every target, not just
      the host, so it broke the Linux build even though it is never
      built. Removed with a quilt patch.<br>
      <br>
      It now builds cleanly with sbuild in a sid chroot, and lintian is
      quiet.<br>
    </p>
    <p>dget -x
<a class="moz-txt-link-freetext" href="https://mentors.debian.net/debian/pool/main/m/moraine/moraine_0.2.1-1.dsc">https://mentors.debian.net/debian/pool/main/m/moraine/moraine_0.2.1-1.dsc</a><br>
      <br>
      I am still learning this as I go, so I really do appreciate you
      taking the time. Removing the moreinfo tag with this mail, and I
      am around if you spot anything else.<br>
      <br>
      Best regards,<br>
      Jonaz Thern</p>
    <div class="moz-cite-prefix">On 7/22/26 13:39, Simon Quigley wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:[email protected]">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="auto">Hello,<br>
        <br>
        Thanks for the update here. It seems like you've addressed most
        of or all of the points.<br>
        <br>
        Could you please remove the moreinfo tag once a new version is
        on Mentors?<br>
        <br>
        Thanks,<br>
        Simon</div>
      <br>
      <br>
      <div class="gmail_quote">
        <div dir="auto">On July 17, 2026 3:58:09 PM CDT, Thern AI
          Solutions <a class="moz-txt-link-rfc2396E" href="mailto:[email protected]">&lt;[email protected]&gt;</a> wrote:</div>
        <blockquote class="gmail_quote"
style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
          <pre class="net-thunderbird-android__plain-text-message-pre"><div
          dir="auto">Hello Simon, and thanx for contacting me. First of all, sorry for the late reply. 3 kids, 2 jobs (1 wich is my own business) and a hours takes alot of time, and Moraine is something I enjoy working on whenever I get a few hours for myself.

Thank you so much for taking the time to go through this in such detail. I'm still fairly new to Debian packaging and learning something new with every round of feedback, so this is genuinely a big help to me. I've addressed all five points:

1. Changelog
   Collapsed it down to a single initial entry and corrected the version to 0.2.0-1 — I hadn't realised a first upload should just be one "Initial release" entry rather than carrying the whole history.

2. Copyright / license name
   Renamed the license from "MIT" to "Expat" in debian/copyright. Good learn that Expat is the correct name for this exact license text in Debian.

3. Standards-Version and control fields
   Bumped Standards-Version to 4.7.4 and dropped both Rules-Requires-Root: no and Priority: optional from the source stanza.

4. debhelper compat
   Upgraded to debhelper-compat 14.

5. Watch file
   Upgraded to version 5. I learned along the way that v5 is a new deb822-style format rather than just a version-number bump, so I rewrote it with the Version/Source/Mode/Matching-Pattern fields (still tracking the git tags).

All five are done in the packaging. I'll give it a final lintian run in a clean unstable chroot and upload the corrected 0.2.0-1 to mentors. Please let me know if there's anything else I should fix — I really appreciate the guidance.

Thanks again,
Jonaz

On 7/14/26 23:18, Simon Quigley wrote:
</div><blockquote class="gmail_quote"
style="margin-bottom: 1ex; --net-thunderbird-android__blockquote-default-border-color: #729fcf;"><div
          dir="auto">Control: tags -1 +moreinfo

Hello,

Thank you for your work here. A few things:
- Please only keep one changelog entry, the initial one, with a corrected version. The additional changelog entries are not needed.
- In the license file, it is expected to use the license name "Expat" instead of "MIT," please fix that.
- Please update Standards-Version to 4.7.4, dropping Rules-Requires-Root: no and Priority: optional.
- Please consider upgrading to debhelper-compat 14.
- Please upgrade the watch file to version 5.

I also can't get it to build, see the attached log.

If this is a Rust package, you might want to include it in the debcargo-conf monorepo following their docs: <a
          href="https://rust-team.pages.debian.net/book/"
          moz-do-not-send="true" class="moz-txt-link-freetext">https://rust-team.pages.debian.net/book/</a>

Please remove the moreinfo tag once you're ready for another review. Feel free to CC me, if I'm available I can re-review.

Best regards,
Simon Quigley
<a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a>
</div></blockquote></pre>
        </blockquote>
      </div>
    </blockquote>
  </body>
</html>

--------------9UND7ksRQDqjLMCFlgUrYwMh--