Bug#1141175: RFS: moraine/0.1.1-1 [ITP] -- snapshot backup over SSH/rsync and rclone

------TP1Z2VXOYST0NWHRO7P0MHDQ7F1ZQE
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

Control: tags -1 + moreinfo

Hello Jonaz,

Thanks for the quick followup! Rainy days do indeed make for good FOSS day=
s=2E ;)

I have reviewed the package again, and just have a few minor comments, the=
 first of which unfortunately is blocking:
 - In appstream-metadata-license=2Epatch I see you corrected the license e=
ntry=2E If I didn't know any better, this looks suspicious, simply because =
you have "Forwarded" set to "not-needed" and this is a license change=2E Yo=
u are upstream, so the best way to handle this in my opinion would be to ma=
ke the change in an upstream commit and link to it in the patch header, or =
make a new release entirely=2E I don't want to confuse the Debian DFSG Team=
=2E :) (see https://dep-team=2Epages=2Edebian=2Enet/deps/dep3/ if you haven=
't already=2E)
 - I would recommend strengthening your upstream metadata file, there are =
tons of options: https://dep-team=2Epages=2Edebian=2Enet/deps/dep12/
 - In the copyright file, since you're upstream, you can just have one sta=
nza for your copyright instead of one for * and one for debian/*=2E
 - Since you're upstream, please upstream the manpage=2E

Otherwise, this package looks much better=2E Let me know if you have furth=
er questions, and please remove the moreinfo tag once you have another iter=
ation ready=2E

Best regards,
Simon Quigley
tsimonq2@debian=2Eorg

On July 22, 2026 7:19:45 AM CDT, Thern AI Solutions <info@thern=2Eio> wrot=
e:
>Control: tags -1 - moreinfo
>
>Hello Simon, hope you're having a great summer so far! Raining here in Sw=
eden, so a perfect time to do some FOSS work :)
>
>moraine 0=2E2=2E1-1 is now on mentors, and I owe you a small confession: =
when I wrote last time that all five points were done, they were done in my=
 head and in my working copy, but they never made it into the package sitti=
ng on mentors=2E You were reviewing the old one=2E Sorry about that=2E This=
 time I checked the uploaded source instead of trusting my own memory=2E I'=
m still VERY new to this, but loving every minute of developing this beauty=
!
>
>What is actually in this upload:
>
>- debian/changelog is a single "Initial release=2E (Closes: #1141131)" en=
try=2E
>- debian/copyright says "Expat" instead of "MIT"=2E
>- Standards-Version is 4=2E7=2E4, and Priority and Rules-Requires-Root ar=
e gone=2E
>- debhelper-compat is 14, plus dh-sequence-single-binary, which dh asks f=
or explicitly in compat 14=2E
>- debian/watch is the version 5 deb822 format=2E
>
>Your build log was the most useful part of the review, so thank you for a=
ttaching it=2E It turned out there were two crates that are not in Debian, =
and cargo resolves both of them even though neither is ever compiled here:
>
>- ksni, the system-tray icon=2E debian/rules now builds with --no-default=
-features --features gui, so the tray is simply left out=2E The GUI already=
 has a #[cfg(not(feature =3D "tray"))] path for platforms without a tray, s=
o nothing else changes=2E
>- winresource, a Windows-only build-dependency that build=2Ers uses under=
 #[cfg(windows)] to embed the icon into the =2Eexe=2E Cargo resolves target=
-specific dependencies for every target, not just the host, so it broke the=
 Linux build even though it is never built=2E Removed with a quilt patch=2E
>
>It now builds cleanly with sbuild in a sid chroot, and lintian is quiet=
=2E
>
>dget -x https://mentors=2Edebian=2Enet/debian/pool/main/m/moraine/moraine=
_0=2E2=2E1-1=2Edsc
>
>I am still learning this as I go, so I really do appreciate you taking th=
e time=2E Removing the moreinfo tag with this mail, and I am around if you =
spot anything else=2E
>
>Best regards,
>Jonaz Thern
>
>On 7/22/26 13:39, Simon Quigley wrote:
>> Hello,
>>=20
>> Thanks for the update here=2E It seems like you've addressed most of or=
 all of the points=2E
>>=20
>> Could you please remove the moreinfo tag once a new version is on Mento=
rs?
>>=20
>> Thanks,
>> Simon
>>=20
>>=20
>> On July 17, 2026 3:58:09 PM CDT, Thern AI Solutions <info@thern=2Eio> w=
rote:
>>=20
>>     Hello Simon, and thanx for contacting me=2E First of all, sorry for
>>     the late reply=2E 3 kids, 2 jobs (1 wich is my own business) and a
>>     hours takes alot of time, and Moraine is something I enjoy working
>>     on whenever I get a few hours for myself=2E Thank you so much for
>>     taking the time to go through this in such detail=2E I'm still
>>     fairly new to Debian packaging and learning something new with
>>     every round of feedback, so this is genuinely a big help to me=2E
>>     I've addressed all five points: 1=2E Changelog =C2=A0 =C2=A0Collaps=
ed it down
>>     to a single initial entry and corrected the version to 0=2E2=2E0-1 =
=E2=80=94 I
>>     hadn't realised a first upload should just be one "Initial
>>     release" entry rather than carrying the whole history=2E 2=2E
>>     Copyright / license name =C2=A0 =C2=A0Renamed the license from "MIT=
" to
>>     "Expat" in debian/copyright=2E Good learn that Expat is the correct
>>     name for this exact license text in Debian=2E 3=2E Standards-Versio=
n
>>     and control fields =C2=A0 =C2=A0Bumped Standards-Version to 4=2E7=
=2E4 and
>>     dropped both Rules-Requires-Root: no and Priority: optional from
>>     the source stanza=2E 4=2E debhelper compat =C2=A0 =C2=A0Upgraded to
>>     debhelper-compat 14=2E 5=2E Watch file =C2=A0 =C2=A0Upgraded to ver=
sion 5=2E I
>>     learned along the way that v5 is a new deb822-style format rather
>>     than just a version-number bump, so I rewrote it with the
>>     Version/Source/Mode/Matching-Pattern fields (still tracking the
>>     git tags)=2E All five are done in the packaging=2E I'll give it a
>>     final lintian run in a clean unstable chroot and upload the
>>     corrected 0=2E2=2E0-1 to mentors=2E Please let me know if there's
>>     anything else I should fix =E2=80=94 I really appreciate the guidan=
ce=2E
>>     Thanks again, Jonaz On 7/14/26 23:18, Simon Quigley wrote:
>>=20
>>         Control: tags -1 +moreinfo Hello, Thank you for your work
>>         here=2E A few things: - Please only keep one changelog entry,
>>         the initial one, with a corrected version=2E The additional
>>         changelog entries are not needed=2E - In the license file, it i=
s
>>         expected to use the license name "Expat" instead of "MIT,"
>>         please fix that=2E - Please update Standards-Version to 4=2E7=
=2E4,
>>         dropping Rules-Requires-Root: no and Priority: optional=2E -
>>         Please consider upgrading to debhelper-compat 14=2E - Please
>>         upgrade the watch file to version 5=2E I also can't get it to
>>         build, see the attached log=2E If this is a Rust package, you
>>         might want to include it in the debcargo-conf monorepo
>>         following their docs: https://rust-team=2Epages=2Edebian=2Enet/=
book/
>>         Please remove the moreinfo tag once you're ready for another
>>         review=2E Feel free to CC me, if I'm available I can re-review=
=2E
>>         Best regards, Simon Quigley tsimonq2@debian=2Eorg 
------TP1Z2VXOYST0NWHRO7P0MHDQ7F1ZQE
Content-Type: text/html;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!doctype html>
<html>
  <head>
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-=
8">
  </head>
  <body><div dir=3D"auto">Control: tags -1 + moreinfo<br><br>Hello Jonaz,<=
br><br>Thanks for the quick followup! Rainy days do indeed make for good FO=
SS days=2E ;)<br><br>I have reviewed the package again, and just have a few=
 minor comments, the first of which unfortunately is blocking:<br> - In app=
stream-metadata-license=2Epatch I see you corrected the license entry=2E If=
 I didn't know any better, this looks suspicious, simply because you have "=
Forwarded" set to "not-needed" and this is a license change=2E You are upst=
ream, so the best way to handle this in my opinion would be to make the cha=
nge in an upstream commit and link to it in the patch header, or make a new=
 release entirely=2E I don't want to confuse the Debian DFSG Team=2E :) (se=
e <a href=3D"https://dep-team=2Epages=2Edebian=2Enet/deps/dep3/">https://de=
p-team=2Epages=2Edebian=2Enet/deps/dep3/</a>=C2=A0if you haven't already=2E=
)<br> - I would recommend strengthening your upstream metadata file, there =
are tons of options: <a href=3D"https://dep-team=2Epages=2Edebian=2Enet/dep=
s/dep12/">https://dep-team=2Epages=2Edebian=2Enet/deps/dep12/</a><br> - In =
the copyright file, since you're upstream, you can just have one stanza for=
 your copyright instead of one for * and one for debian/*=2E<br> - Since yo=
u're upstream, please upstream the manpage=2E<br><br>Otherwise, this packag=
e looks much better=2E Let me know if you have further questions, and pleas=
e remove the moreinfo tag once you have another iteration ready=2E<br><br>B=
est regards,<br>Simon Quigley<br>tsimonq2@debian=2Eorg</div><br><br><div cl=
ass=3D"gmail_quote"><div dir=3D"auto">On July 22, 2026 7:19:45 AM CDT, Ther=
n AI Solutions &lt;info@thern=2Eio&gt; wrote:</div><blockquote class=3D"gma=
il_quote" style=3D"margin: 0pt 0pt 0pt 0=2E8ex; border-left: 1px solid rgb(=
204, 204, 204); padding-left: 1ex;">

    <p>Control: tags -1 - moreinfo<br>
      <br>
      Hello Simon, hope you're having a great summer so far! Raining
      here in Sweden, so a perfect time to do some FOSS work :)</p>
    <p>moraine 0=2E2=2E1-1 is now on mentors, and I owe you a small
      confession: when I wrote last time that all five points were done,
      they were done in my head and in my working copy, but they never
      made it into the package sitting on mentors=2E You were reviewing
      the old one=2E Sorry about that=2E This time I checked the uploaded
      source instead of trusting my own memory=2E I'm still VERY new to
      this, but loving every minute of developing this beauty!<br>
      <br>
      What is actually in this upload:<br>
      <br>
      - debian/changelog is a single "Initial release=2E (Closes:
      #1141131)" entry=2E<br>
      - debian/copyright says "Expat" instead of "MIT"=2E<br>
      - Standards-Version is 4=2E7=2E4, and Priority and Rules-Requires-Ro=
ot
      are gone=2E<br>
      - debhelper-compat is 14, plus dh-sequence-single-binary, which dh
      asks for explicitly in compat 14=2E<br>
      - debian/watch is the version 5 deb822 format=2E<br>
      <br>
      Your build log was the most useful part of the review, so thank
      you for attaching it=2E It turned out there were two crates that are
      not in Debian, and cargo resolves both of them even though neither
      is ever compiled here:<br>
    </p>
    <p>- ksni, the system-tray icon=2E debian/rules now builds with
      --no-default-features --features gui, so the tray is simply left
      out=2E The GUI already has a #[cfg(not(feature =3D "tray"))] path fo=
r
      platforms without a tray, so nothing else changes=2E<br>
      - winresource, a Windows-only build-dependency that build=2Ers uses
      under #[cfg(windows)] to embed the icon into the =2Eexe=2E Cargo
      resolves target-specific dependencies for every target, not just
      the host, so it broke the Linux build even though it is never
      built=2E Removed with a quilt patch=2E<br>
      <br>
      It now builds cleanly with sbuild in a sid chroot, and lintian is
      quiet=2E<br>
    </p>
    <p>dget -x
<a class=3D"moz-txt-link-freetext" href=3D"https://mentors=2Edebian=2Enet/=
debian/pool/main/m/moraine/moraine_0=2E2=2E1-1=2Edsc">https://mentors=2Edeb=
ian=2Enet/debian/pool/main/m/moraine/moraine_0=2E2=2E1-1=2Edsc</a><br>
      <br>
      I am still learning this as I go, so I really do appreciate you
      taking the time=2E Removing the moreinfo tag with this mail, and I
      am around if you spot anything else=2E<br>
      <br>
      Best regards,<br>
      Jonaz Thern</p>
    <div class=3D"moz-cite-prefix">On 7/22/26 13:39, Simon Quigley wrote:<=
br>
    </div>
    <blockquote type=3D"cite" cite=3D"mid:5B303034-5BE9-42FC-8BA9-801C44F8=
527B@tsimonq2=2Enet">
      <meta http-equiv=3D"content-type" content=3D"text/html; charset=3DUT=
F-8">
      <div dir=3D"auto">Hello,<br>
        <br>
        Thanks for the update here=2E It seems like you've addressed most
        of or all of the points=2E<br>
        <br>
        Could you please remove the moreinfo tag once a new version is
        on Mentors?<br>
        <br>
        Thanks,<br>
        Simon</div>
      <br>
      <br>
      <div class=3D"gmail_quote">
        <div dir=3D"auto">On July 17, 2026 3:58:09 PM CDT, Thern AI
          Solutions <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:info=
@thern=2Eio">&lt;info@thern=2Eio&gt;</a> wrote:</div>
        <blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0=
=2E8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
          <pre class=3D"net-thunderbird-android__plain-text-message-pre"><=
div dir=3D"auto">Hello Simon, and thanx for contacting me=2E First of all, =
sorry for the late reply=2E 3 kids, 2 jobs (1 wich is my own business) and =
a hours takes alot of time, and Moraine is something I enjoy working on whe=
never I get a few hours for myself=2E

Thank you so much for taking the time to go through this in such detail=2E=
 I'm still fairly new to Debian packaging and learning something new with e=
very round of feedback, so this is genuinely a big help to me=2E I've addre=
ssed all five points:

1=2E Changelog
&nbsp; &nbsp;Collapsed it down to a single initial entry and corrected the=
 version to 0=2E2=2E0-1 =E2=80=94 I hadn't realised a first upload should j=
ust be one "Initial release" entry rather than carrying the whole history=
=2E

2=2E Copyright / license name
&nbsp; &nbsp;Renamed the license from "MIT" to "Expat" in debian/copyright=
=2E Good learn that Expat is the correct name for this exact license text i=
n Debian=2E

3=2E Standards-Version and control fields
&nbsp; &nbsp;Bumped Standards-Version to 4=2E7=2E4 and dropped both Rules-=
Requires-Root: no and Priority: optional from the source stanza=2E

4=2E debhelper compat
&nbsp; &nbsp;Upgraded to debhelper-compat 14=2E

5=2E Watch file
&nbsp; &nbsp;Upgraded to version 5=2E I learned along the way that v5 is a=
 new deb822-style format rather than just a version-number bump, so I rewro=
te it with the Version/Source/Mode/Matching-Pattern fields (still tracking =
the git tags)=2E

All five are done in the packaging=2E I'll give it a final lintian run in =
a clean unstable chroot and upload the corrected 0=2E2=2E0-1 to mentors=2E =
Please let me know if there's anything else I should fix =E2=80=94 I really=
 appreciate the guidance=2E

Thanks again,
Jonaz

On 7/14/26 23:18, Simon Quigley wrote:
</div><blockquote class=3D"gmail_quote" style=3D"margin-bottom: 1ex; --net=
-thunderbird-android__blockquote-default-border-color: #729fcf;"><div dir=
=3D"auto">Control: tags -1 +moreinfo

Hello,

Thank you for your work here=2E A few things:
- Please only keep one changelog entry, the initial one, with a corrected =
version=2E The additional changelog entries are not needed=2E
- In the license file, it is expected to use the license name "Expat" inst=
ead of "MIT," please fix that=2E
- Please update Standards-Version to 4=2E7=2E4, dropping Rules-Requires-Ro=
ot: no and Priority: optional=2E
- Please consider upgrading to debhelper-compat 14=2E
- Please upgrade the watch file to version 5=2E

I also can't get it to build, see the attached log=2E

If this is a Rust package, you might want to include it in the debcargo-co=
nf monorepo following their docs: <a href=3D"https://rust-team=2Epages=2Ede=
bian=2Enet/book/" moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext">=
https://rust-team=2Epages=2Edebian=2Enet/book/</a>

Please remove the moreinfo tag once you're ready for another review=2E Fee=
l free to CC me, if I'm available I can re-review=2E

Best regards,
Simon Quigley
<a class=3D"moz-txt-link-abbreviated" href=3D"mailto:tsimonq2@debian=2Eorg=
">tsimonq2@debian=2Eorg</a>
</div></blockquote></pre>
        </blockquote>
      </div>
    </blockquote>
  </blockquote></div></body>
</html>

------TP1Z2VXOYST0NWHRO7P0MHDQ7F1ZQE--