Re: Request for review - A number of packages

gregor herrmann <[email protected]> Tue, 11 Jul 2023 23:40:04 +0200
Newsgroups	gmane.linux.debian.devel.perl
Message-ID	<[email protected]>
On Wed, 12 Jul 2023 01:53:33 +1200, Andrew Ruthven wrote:

> [libbadger-perl]
> > > > > > 
> > > > > Given the shipped tests pass, is it acceptable to filter these out
> > > > > of autopkgtests?
> > > > If we have a reason to believe that the "-c" failures are harmless
> > > > then yes; that would require getting a deeper understanding of this
> > > > whole project that I currently have :)
> > > I *think* that the modules aren't intended to be used standalone, so
> > > could be skipped.
> > Alright, in that case adding the 2 filenames to
> > debian/tests/pkg-perl/syntax-skip should do the trick.

(Just briefly, as I'm travelling):

> Except that this file appears to apply to runtime-deps-and-
> recommends.d/syntax.t . The tests which are failing are in runtime-
> deps.d/use.t . 

That doesn't match my memory, and luckily I still have a log:

 38s /usr/share/pkg-perl-autopkgtest/runtime-deps.d/use.t ..
 38s 1..4
 38s ok 1 -  /usr/bin/perl -w -M"Badger" -e 1 2>&1 exited successfully
 38s ok 2 -  /usr/bin/perl -w -M"Badger" -e 1 2>&1 produced no (non-whitelisted) output
 38s ok 3 - env PERL_DL_NONLAZY=1  /usr/bin/perl -w -M"Badger" -e 1 2>&1 exited successfully
 38s ok 4 - env PERL_DL_NONLAZY=1  /usr/bin/perl -w -M"Badger" -e 1 2>&1 produced no (non-whitelisted) output
 38s ok
 38s All tests successful.
 38s Files=1, Tests=4,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.15 cusr  0.03 csys =  0.20 CPU)
 38s Result: PASS

So use.t, as expected, only tests one file (Badger.pm) and passes.

 43s autopkgtest [15:50:13]: test autodep8-perl-recommends: [-----------------------
 44s
 44s     #   Failed test '/usr/bin/perl -wc /usr/share/perl5/Badger/Class/Methods.pm exited successfully'
 44s     #   at /usr/share/pkg-perl-autopkgtest/runtime-deps-and-recommends.d/syntax.t line 124.
 44s
 44s     #   Failed test '/usr/bin/perl -wc /usr/share/perl5/Badger/Codecs.pm exited successfully'
 44s     #   at /usr/share/pkg-perl-autopkgtest/runtime-deps-and-recommends.d/syntax.t line 124.
 47s     # Looks like you failed 2 tests of 88.
 47s
 47s #   Failed test 'all modules in libbadger-perl pass the syntax check'
 47s #   at /usr/share/pkg-perl-autopkgtest/runtime-deps-and-recommends.d/syntax.t line 127.
 47s # Looks like you failed 1 test of 4.
 47s /usr/share/pkg-perl-autopkgtest/runtime-deps-and-recommends.d/syntax.t ..

And the failures are in syntax.t which runs perl -wc on all files.

> (And it seems that d/tests/pkg-perl/syntax-skip doesn't support comments,
> whereas the files for use.t do support comments.)

Doesn't match my memory either, and:

% grep '^#' */debian/tests/pkg-perl/syntax-skip | wc -l
248

In fact I think most of our d/tests/pkg-perl/syntax-skip have
comments. And sometimes only consists of a comment:

% grep '^.*Empty' */debian/tests/pkg-perl/syntax-skip | wc -l
53

E.g.:

% cat pkg-perl-tools/debian/tests/pkg-perl/syntax-skip
# Empty file to check everything despite Suggests


> Would you be open to a merge request here?

In general: yes of course, but at the moment I don't yet see the
necessity for a change :)

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-
signature.asc (application/pgp-signature, 963 B)