review for python-vtracer/0.6.15-1

--Sig_/LGdOk0vXx=TI3w/3HcY0RM8
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

hi Michele,

I took a look at the python-vtracer package, up for sponsorship in
the Python team:

* watch: broken, mixed v4 and v5 syntax (already fixed in git).

* CI: d/salsa-ci.yml exists but the CI isn't enabled on salsa.

* rules: 'export DEB_CARGO_CRATE=3Dvtracer_0.6.12' but pkg is at
  v0.6.15; you probably don't want to hardcode the version there.=20
* rules: both overrides could use execute_before.

* patches: please don't delete files via patches. Doing so is
  inefficient and noisy, with large diffs every time the deleted file
  has any minor change. Just list the relevant file(s) in d/clean
  instead.

* tests: when writing autopkgtests in Python packages, you want to
  loop over all supported Python versions, and *not* run things from
  the extracted source directory (use the provided empty directory in
  $AUTOPKGTEST_TMP instead). Plenty of examples at [1].


Given the changes needed and lack of time on my end, I stopped
reviewing at this point, so I can't say anything with regards to the
binary pkg yet. Once the above comments have been addressed, simply
re-add the package to the IRC channel topic and/or ping me by e-mail.


[1]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Ftests%2F%20(py3=
versions%20-s)&literal=3D1&perpkg=3D1

--Sig_/LGdOk0vXx=TI3w/3HcY0RM8
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmpjSdsACgkQQoMEoXSN
zHqXcA/8CiCflZIAQDWYQnd547chDyF+cyTftMGR3rCoOgwq4R6XIU32frSBLi0Z
uQdKg83jVvA0D7d4YEmeW3O0QMVhM6wnSIXkEM1j0u6V4RPGZlFlmyN3gDpUDqnK
bNA6cVt3urLys7igkN9Lxbu3cl9enD/GBB+fp3z6yEztJq8OsvBF5oXzvV/2Sk+r
BGZMT+wJLjVICIEqUEqvG0j7n+pTe9isFNDAjfUv38kbie8Z9p5q8HjMbhaU5JP2
F9a+EVi1qebXOsQBhpRBoVHKbQ0macytgTt+6Cfcp356/87a4jt3zQvu3Y6yInSG
SyAkQt+x3171G3XZIgQF1wTzPhxEu3NZLnfc0dlfXOKfT19+B9SSXOYukmaL36kJ
tuoJ0Lol7fMnf+J+1+E4JgGo9d7fszoQOcww/nxYwAAsbOWMYBcc0yu/tueXwYfi
DYP3m1o3iM2lOn1ar7Y3uLrED65QV1YBiIrWvBhRHJ1dXUqWgdq7F1mUq5fynsYr
tja088QEfZXYn3u6ZIcWHkRBuTOMOpH4dpCuZ4ZVfr4zU7imXC5AAB0uNoINtqLy
QkQyW/PzNnOmzrKB0ooFgmqq+lyl8GxgpCMr+zFTcRBVdgBl467P/p0OOTiWM0Wb
h9aUdF0U8SvNYpe0A7wkXPeQZcdpUdXcddtVVqBUqIL3U7SP6r0=
=YRps
-----END PGP SIGNATURE-----

--Sig_/LGdOk0vXx=TI3w/3HcY0RM8--