Re: review for python-vtracer/0.6.15-1

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------0f905372a2539bdd07bcb2494a651033c047575f06826bcd6fd7408d45dac082
Content-Type: multipart/mixed;boundary=---------------------0b4e8b9d514f3ccadeb52e4257ee8cb9

-----------------------0b4e8b9d514f3ccadeb52e4257ee8cb9
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8

Hi Jeroen,

Thanks a lot for looking into this.

I addressed the comments and pushed the changes.

  * watch: kept the existing git fix. My new commit is based on the remote
    commit that fixed debian/watch.

  * CI: removed debian/salsa-ci.yml, since CI is not enabled for the Salsa
    project.

  * rules: DEB_CARGO_CRATE now derives from DEB_VERSION_UPSTREAM instead o=
f
    hardcoding 0.6.12.

  * rules: converted the dh_auto_configure and dh_auto_clean overrides to
    execute_before_dh_auto_configure and execute_before_dh_auto_clean.

  * patches: removed the Cargo.lock deletion patch and listed Cargo.lock i=
n
    debian/clean instead.

  * tests: updated the autopkgtest to run from $AUTOPKGTEST_TMP and loop o=
ver
    all supported Python versions via py3versions.

  QA:
  * sbuild -d unstable succeeded on amd64.
  * lintian --display-info --pedantic on the generated .changes passed cle=
anly.
  * The explicit autopkgtest import test passed in an unstable unshare tes=
tbed.
    autopkgtest exits 8 because the available tests are superficial only; =
the
    summary is: import PASS (superficial).

Cheers

Mike

Michele Cane, PhD

On Friday, 24 July 2026 at 13:17, Jeroen Ploemen <[email protected]> wrote:

> hi Michele,
> =


> I took a look at the python-vtracer package, up for sponsorship in
> the Python team:
> =


> * watch: broken, mixed v4 and v5 syntax (already fixed in git).
> =


> * CI: d/salsa-ci.yml exists but the CI isn't enabled on salsa.
> =


> * rules: 'export DEB_CARGO_CRATE=3Dvtracer_0.6.12' but pkg is at
>   v0.6.15; you probably don't want to hardcode the version there. =


> * rules: both overrides could use execute_before.
> =


> * patches: please don't delete files via patches. Doing so is
>   inefficient and noisy, with large diffs every time the deleted file
>   has any minor change. Just list the relevant file(s) in d/clean
>   instead.
> =


> * tests: when writing autopkgtests in Python packages, you want to
>   loop over all supported Python versions, and *not* run things from
>   the extracted source directory (use the provided empty directory in
>   $AUTOPKGTEST_TMP instead). Plenty of examples at [1].
> =


> =


> Given the changes needed and lack of time on my end, I stopped
> reviewing at this point, so I can't say anything with regards to the
> binary pkg yet. Once the above comments have been addressed, simply
> re-add the package to the IRC channel topic and/or ping me by e-mail.
> =


> =


> [1]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Ftests%2F%20(=
py3versions%20-s)&literal=3D1&perpkg=3D1
> =


-----------------------0b4e8b9d514f3ccadeb52e4257ee8cb9
Content-Type: application/pgp-keys; filename="publickey - [email protected] - 0xC017295D.asc"; name="publickey - [email protected] - 0xC017295D.asc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="publickey - [email protected] - 0xC017295D.asc"; name="publickey - [email protected] - 0xC017295D.asc"

LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgp4ak1FWWtyR1N4WUpLd1lCQkFI
YVJ3OEJBUWRBSVRTb0djUkJVZFZZQ2poazdlcE9WWDhtak9PRXFPelgKZjI0bUpWd1pLNDdOTDIx
cFkyaGxiR1V1WTJGdVpVQndjbTkwYjI0dWJXVWdQRzFwWTJobGJHVXVZMkZ1ClpVQndjbTkwYjI0
dWJXVSt3bzhFRUJZS0FDQUZBbUpLeGtzR0N3a0hDQU1DQkJVSUNnSUVGZ0lCQUFJWgpBUUliQXdJ
ZUFRQWhDUkNrUnNyaEZFd3NtaFloQk1BWEtWMW1SeDlFaEFxU1BxUkd5dUVVVEN5YVk3Z0EKL2lX
TEZadzMva1BycjZNTDQyMC9JeWdZNGlBbGZpNlZmVnd0ZkRQZ1FDak1BUURZZUtEeEtJSXpWckpQ
CmF6NVhvbCtpT0hzMFNKV0twb0FsdjIzZWV6Y3dBYzQ0QkdKS3hrc1NDaXNHQVFRQmwxVUJCUUVC
QjBEdQp4NkdOR1NTZXhKSEFUSWlIYU1zSGc0L2ZpeGJGb1NPZm96ZzZsQ1BZZFFNQkNBZkNlQVFZ
RmdnQUNRVUMKWWtyR1N3SWJEQUFoQ1JDa1JzcmhGRXdzbWhZaEJNQVhLVjFtUng5RWhBcVNQcVJH
eXVFVVRDeWFpSWdCCkFNdG4wMmloaGx5VnV1YXNUclZYbDdjdVpJelNLZ1ZyRkowUnpoMTZrOUE3
QVFEMkt0R2lSQ1BlalNOQQorS1lYYmJOcVU1OGlPQm5yWGVoOEE3MExobTZBQmc9PQo9LzF2dwot
LS0tLUVORCBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCg==
-----------------------0b4e8b9d514f3ccadeb52e4257ee8cb9--

--------0f905372a2539bdd07bcb2494a651033c047575f06826bcd6fd7408d45dac082
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wrsEARYKAG0FgmpjYPQJEKRGyuEUTCyaRRQAAAAAABwAIHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmelNmwRSELif67Q8qpoH3Qah81g+ljp92zm3G85
Yo1M7xYhBMAXKV1mRx9EhAqSPqRGyuEUTCyaAACRqQEAkh8nZ6GAPUXPglKt
SicIf0LkJWcUHmENjPsMquwqpscBANRuGkrTn00yCaE/CXCBpjYTDP+Z0tL7
AmLb276sbq0N
=rkMT
-----END PGP SIGNATURE-----


--------0f905372a2539bdd07bcb2494a651033c047575f06826bcd6fd7408d45dac082--