review for python-pyvips/3.1.1-1

--Sig_/hwDxcnIT5.a56fYHTodHFwX
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

hi Mike,

I took a look at the python-pyvips package, up for sponsorship in the
Python team:

* changelog/control: mr. Modaresi is still listed as uploader, but no
  longer active as a Debian maintainer.

* control: missing Built-Using: ${sphinxdoc:Built-Using} on the
  documentation package.

* examples: these currently get installed into the module package,
  but probably belong in the documentation package. Examples are
  after all a form of documentation.

* rules: if test_from_numpy is only problematic on 32bit archs,
  setting the PYTEST_ADDOPTS variable could be made conditional on
  that (so the test still runs on other archs). IIRC, the relevant
  variable one could use is DEB_HOST_ARCH_BITS.

* rules/control: sphinx-build is called even if the 'nodoc' build
  profile is used. Please honour the build profile (examples at [1]);
  documentation-only build-dependencies could also be marked <!nodoc>.

* patches: the comment_get_documenter patch looks like it isn't
  Debian-specific and thus could be forwarded upstream?

* lintian: privacy-breach-generic has been overridden, but lintian
  identified a real issue (remote build status badge image, via
  doc/README.rst:4). Please add a patch for that and remove the
  override.

* what is pyvips/pyvips_build.py used for? Is it just part of the
  build process via setup.py, and if so, does it need to be
  installed? Asking since it's currently part of the module, but it
  needs python3-pkgconfig which isn't a dependency of the binary
  package (only a build-dep right now).


Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.


[1]https://codesearch.debian.net/search?q=3Dpath%3Adebian%2Frules%20filter%=
20nodoc&literal=3D1&perpkg=3D1

--Sig_/hwDxcnIT5.a56fYHTodHFwX
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmpmP1UACgkQQoMEoXSN
zHo8sxAA24qFmWUn8gniNHYFaSl/HNt1EiNy2n0CP30xed/S0pXmZC337oJ32f9L
BLd0uo35Mq3Cw8R/Uu1skCGH9voiqmY2cf/tuizvCZmKj4g4rKqdMF6yPLjXRG/6
g5CzH63alBtrD3wf4JTSlFdNTI2Jmz68T+nU/g3k7n/mafvNBmI+wTITJpMropLL
DoiTD6hLP6x6e9Xsri/h4DM8zSATIqBclUI84I9Dm3Q5wjuYnEhmJoXifvfUxGQE
bpiumVYes+9GuDPgrmc+oK6pdX07PGFefEUzYSJrH+VQLeW9FkOJdDCf2gEXOc4U
j/w+xeXVwyXl8jXZJusu+gnPqcuntbuAptS4ZMBwrL6I0SF1ZwI0F1/oiXGk/uEV
WfB4gf2mmzl7ZgDUUPLU9cAHRxj0Y7Y+ZqAjxoo0hbiVVm7V7v2Aad1nznUzldcS
MhgoirUrm3SCOuwX4rgAYoXkpvYhvQnmq9sC7ewwOwPSzM7NK9BnSKL7PmB/LyMZ
gmj2oIvtDudL8ppV+KDc5BKjyl9wKus53COxI09mx1l03x/2gPEJK0wV75hlDU3y
hPdMH9BhsTjnJm+g9WyJrCqKhpjXPLndRzpyS6SO2DOKI1l05xaB9kyvSvWnOBri
+kknECTX6KQA8eJWa4ymqT1G+PXmM7x0/5uJfz5EicrXj85Uub8=
=nPPN
-----END PGP SIGNATURE-----

--Sig_/hwDxcnIT5.a56fYHTodHFwX--