Bug#750378: marked as done (freebsd-buildutils: Conflicting declarations of struct _node may result in invalid access)

"Debian Bug Tracking System" <[email protected]> Fri, 26 Jul 2024 18:45:37 +0000
Newsgroups gmane.linux.debian.ports.bsd
Message-ID <[email protected]>
This is a multi-part message in MIME format...

------------=_1722019537-2350142-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your message dated Fri, 26 Jul 2024 18:42:08 +0000
with message-id <[email protected]>
and subject line Bug#1072228: Removed package(s) from unstable
has caused the Debian Bug report #750378,
regarding freebsd-buildutils: Conflicting declarations of struct _node may =
result in invalid access
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


--=20
750378: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D750378
Debian Bug Tracking System
Contact [email protected] with problems

------------=_1722019537-2350142-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.debian.org; 2 Jun 2014 23:55:31 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2-bugs.debian.org_2005_01_02
	(2011-06-06) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.9 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,FROMDEVELOPER,HAS_PACKAGE,PGPSIGNATURE,RCVD_IN_DNSWL_MED
	autolearn=ham version=3.3.2-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 27; hammy, 151; neutral, 163; spammy,
	0. spammytokens: hammytokens:0.000-+--H*c:pgp-sha256, 0.000-+--Usertags,
	0.000-+--pbuilder, 0.000-+--H*u:1.5.21, 0.000-+--H*UA:1.5.21
Return-path: <[email protected]>
Received: from flan-planb.eecs.qmul.ac.uk ([138.37.95.139])
	by buxtehude.debian.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.80)
	(envelope-from <[email protected]>)
	id 1Wrc4f-0006n3-Vn
	for [email protected]; Mon, 02 Jun 2014 23:55:31 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eecs.qmul.ac.uk; s=beta;
	h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=WxHsRVd1HVzp8ODs8wBGWamksd25SI31V3Rhb0hngQ8=;
	b=M4sQhLBKbCcUojW+5zYLhsjLc0vAis9r2ijunqJUiDFhWdJxK/bVIwtMvJjILINAMd5zEkHD8pHDhyyX4jv+kvmQ2Wa9pXERV1UUFVZ0gR22GgkEkn8zTv9MhmGJj6MXjcHNIX52gIYtbIYpTgz6xZxKRW50nYaHVKjflyTxvYw=;
Received: from [176.25.229.20] (helo=l04.Home)
	by smtp.eecs.qmul.ac.uk:587 with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
	authenticated as mt (person) (Exim 4.76_RC2)
	(envelope-from <[email protected]>)
	id 1Wrc4c-0003w4-Mt
	for [email protected]; Tue, 03 Jun 2014 00:55:26 +0100
Date: Tue, 3 Jun 2014 00:55:25 +0100
From: Michael Tautschnig <[email protected]>
To: [email protected]
Subject: freebsd-buildutils: Conflicting declarations of struct _node may
 result in invalid access
Message-ID: <[email protected]>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="twIJdNBdAyMPsp3P"
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Delivered-To: [email protected]


--twIJdNBdAyMPsp3P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: freebsd-buildutils
Version: 10.0-4
Usertags: goto-cc

During a rebuild of all Debian packages in a clean sid chroot (using cowbuilder
and pbuilder) the build failed with the following error. Please note that we
use our research compiler tool-chain (using tools from the cbmc package), which
permits extended reporting on type inconsistencies at link time.

[...]
gcc -O2 -g -Wall -D_GNU_SOURCE -DMACHINE_ARCH='"amd64"' -DMACHINE_MULTIARCH='"x86_64-linux-gnu"' -I/srv/jenkins-slave/workspace/sid-goto-cc-freebsd-buildutils/freebsd-buildutils-10.0/build-tree/src/sys -D_GNU_SOURCE=1 -isystem /usr/include/freebsd  -std=gnu99 -fstack-protector   -o fmtree compare.o crc.o create.o excludes.o misc.o mtree.o spec.o verify.o specspec.o -lbsd

error: conflicting function declarations "mtree_readspec"
old definition in module spec file spec.c line 58
struct _node * (struct _IO_FILE *fi)
new definition in module specspec file extern.h line 44
struct _node * (struct _IO_FILE *)

reason for conflict in types listed below (struct/struct):
composite type component counts differ (22/21)
struct _node {
  struct _node * parent;
  struct _node * child;
  struct _node * prev;
  struct _node * next;
  signed long int st_size;
  struct timespec st_mtim;
  unsigned long int cksum;
  char * md5digest;
  char * sha1digest;
  char * sha256digest;
  char * rmd160digest;
  char * slink;
  unsigned int st_uid;
  unsigned int st_gid;
  unsigned int st_mode;
  unsigned int <padding>;
  unsigned long int st_flags;
  unsigned long int st_nlink;
  unsigned int flags;
  unsigned char type;
  char [1l] name;
  unsigned short int <padding>;
}
struct _node {
  struct _node * parent;
  struct _node * child;
  struct _node * prev;
  struct _node * next;
  signed long int st_size;
  unsigned long int cksum;
  char * md5digest;
  char * sha1digest;
  char * sha256digest;
  char * rmd160digest;
  char * slink;
  unsigned int st_uid;
  unsigned int st_gid;
  unsigned int st_mode;
  unsigned int <padding>;
  unsigned long int st_flags;
  unsigned long int st_nlink;
  unsigned int flags;
  unsigned char type;
  char [1l] name;
  unsigned short int <padding>;
}
*** Error code 64

Stop.
bmake[1]: stopped in /srv/jenkins-slave/workspace/sid-goto-cc-freebsd-buildutils/freebsd-buildutils-10.0/build-tree/src/usr.sbin/mtree
debian/rules:107: recipe for target 'build-stamp' failed
make: *** [build-stamp] Error 1

Observe the missing st_mtim field in the second declaration. Consequently the
offsets of all further members will differ, which will result in wrong (or
invalid) accesses when passing around objects between the two compilation units
(spec and specspec). Indeed this appears to be happening here:

http://sources.debian.net/src/freebsd-buildutils/10.0-4/src/usr.sbin/mtree/specspec.c?hl=249,250#L249

This is a bit of a guess, but I think it's the missing

#include <sys/stat.h>

in specspec.c that is causing this difference.

Best,
Michael


--twIJdNBdAyMPsp3P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: GPGTools - http://gpgtools.org

iQIcBAEBCAAGBQJTjQ7rAAoJEKjvEonjOGdBdH0P/2qAUaPxz0p21+iUARGiayym
4sbfdneTiwy2NvYVJT8O5FWwac+EdlPEPmYj00ptEcPUuEOOR39eLCSXyL5nelqR
MGMDxIpupO6bqpeB4heX4nloAfy53HtDXiu7+DuhrdK0jHjmSGfzaDEiwgHIxv80
i2BSiFavqxKLMrIts3S6W2rVoUtIBmar4U4uEddHThCniPs2oa4T6I8cxSggYAOU
j9UqEFuh5jVPZd4wW3Zw4obFMtoXCnz8x5vmiXkDK8jeCpDh8+7DV9pPyoj6M3ND
+SvItFjzKaVPvdG21VR5qv0FUIaR70+vrJW+Nd0+ek8SS4j2RcM+CNTtSPBKzWTr
/Vqrj0fRxM/fOLtJ34eCjf1EOdCibhy2+IWn5Tz2WpfbuKwEPZVB/xvhNpJ7vDxb
JpSs5yArjllFKgXMD9n+PZ9G72XsWTsf84uTDuU59wAZ6YB8U1VZlxYYMD+WEYTN
jtcsTCSBYyJTw0OfMrYnSHkjdmt5UW46lFOHL06AhRfPsSuy7qVTSt87dOCBW5i4
AoPOl8ZGo03mQW9/VLvXatbuR5IMxHiEh+OO7Qlj/DXCh9wdWO3+QbgYARVfZrmG
MvVd5FUac8Pc3DM/Td/QyK4SjX/Aj0SWbVCExwhap2lTInQ95lMi6oTIxsdnqx2u
e2E/4RkyFpvN277stcf5
=isET
-----END PGP SIGNATURE-----

--twIJdNBdAyMPsp3P--

------------=_1722019537-2350142-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 750378-done) by bugs.debian.org; 26 Jul 2024 18:42:13 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
	(2021-04-09) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-108.0 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HAS_BUG_NUMBER,RCVD_IN_DNSWL_MED,
	SPF_HELO_PASS,SPF_NONE,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,
	VERSION autolearn=ham autolearn_force=no
	version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 17; hammy, 139; neutral, 39; spammy,
	0. spammytokens: hammytokens:0.000-+--HX-Debian:DAK,
	0.000-+--H*rp:D*ftp-master.debian.org,
	0.000-+--Hx-spam-relays-external:sk:fasolo., 0.000-+--H*RU:sk:fasolo.,
	0.000-+--H*r:sk:fasolo.
Return-path: <[email protected]>
Received: from mitropoulos.debian.org ([2001:648:2ffc:deb:216:61ff:fe9d:958d]:48380)
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=mitropoulos.debian.org,[email protected] (verified)
	by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPtM-009qp5-Hx; Fri, 26 Jul 2024 18:42:13 +0000
Received: from [192.91.235.231] (port=38622 helo=fasolo.debian.org)
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=fasolo.debian.org,[email protected] (verified)
	by mitropoulos.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPtL-00Ao8H-J5; Fri, 26 Jul 2024 18:42:10 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=ftp-master.debian.org; s=smtpauto.fasolo; h=Date:Message-Id:
	Content-Transfer-Encoding:Content-Type:Subject:MIME-Version:Cc:To:From:
	Reply-To:Content-ID:Content-Description:In-Reply-To:References;
	bh=Q/GMA/0T8fdt0ucT16HJucH0VPfM0kBvnpANY8sSKa8=; b=Hp4vgFr1RkAKtwgYHzcWpD4KZD
	B1Mlyso79x1C6Y6gSgyEMP/HRcNO2d3eK4NK3g91FX8JswyyiiF2mDUoDjaMijXyDdmJCAvz1o7NB
	dLq+wUAq81Zfs/bZRrISFPoX4y95dzukLzbTtT1HIP9lv7d76LCdm1X1BIt6z9Z7MUoqC18hQEULv
	h++gPeX6/jvijbDTuv6+SYP3oeBd95xecjkHMkDF2I3Zb9pB2VXwT5KECnVr/sH12Qnb47W/++PA/
	47P9mIWlOX+gkr4ILLfvvmPBi4EzmAqKtjj/TphHjMPUAHD0tU3sZBTPhZjMdBIB8FC5AxkR70w07
	6KZ9cvGw==;
Received: from kitterman by fasolo.debian.org with local (Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPtI-005bO3-Kb; Fri, 26 Jul 2024 18:42:08 +0000
From: Debian FTP Masters <[email protected]>
To: [email protected],[email protected],[email protected],[email protected],[email protected],
X-DAK: dak rm
Cc: [email protected]
X-Filler: 42
X-Debian: DAK
Debian: DAK
MIME-Version: 1.0
Subject: Bug#1072228: Removed package(s) from unstable
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <[email protected]>
Date: Fri, 26 Jul 2024 18:42:08 +0000

Version: 10.3~svn296373-7.1+rm

Dear submitter,

as the package freebsd-buildutils has just been removed from the Debian archi=
ve
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1072228

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)
------------=_1722019537-2350142-0--