Bug#580949: marked as done (libnetgraph4: netgraph completely broken)

This is a multi-part message in MIME format...

------------=_1722019533-2350120-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your message dated Fri, 26 Jul 2024 18:40:48 +0000
with message-id <[email protected]>
and subject line Bug#1072229: Removed package(s) from unstable
has caused the Debian Bug report #580949,
regarding libnetgraph4: netgraph completely broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


--=20
580949: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D580949
Debian Bug Tracking System
Contact [email protected] with problems

------------=_1722019533-2350120-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.debian.org; 10 May 2010 04:11:37 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on busoni.debian.org
X-Spam-Level: 
X-Spam-Bayes: score:0.0000 Tokens: new, 32; hammy, 151; neutral, 228; spammy,
	0. spammytokens: hammytokens:0.000-+--H*M:reportbug, 0.000-+--H*MI:reportbug,
	0.000-+--H*x:reportbug, 0.000-+--H*UA:reportbug, 0.000-+--UD:UTF-8
X-Spam-Status: No, score=-9.8 required=4.0 tests=AWL,BAYES_00,
	DATE_IN_PAST_03_06,FOURLA,HAS_PACKAGE,IMPRONONCABLE_2,XMAILER_REPORTBUG
	autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Return-path: <[email protected]>
Received: from h144.c72.b0.tor.eicat.ca ([72.0.72.144] helo=anarcat.ath.cx)
	by busoni.debian.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69)
	(envelope-from <[email protected]>)
	id 1OBKLB-0000Px-1O
	for [email protected]; Mon, 10 May 2010 04:11:37 +0000
Received: from loony.anarcat.ath.cx (unknown [192.168.0.4])
	by anarcat.ath.cx (Postfix) with ESMTP id 814C423E1F;
	Mon, 10 May 2010 00:11:31 -0400 (EDT)
Received: by loony.anarcat.ath.cx (Postfix, from userid 1000)
	id 2A2A8398A6; Sun,  9 May 2010 20:11:33 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: antoine beaupre <[email protected]>
To: Debian Bug Tracking System <[email protected]>
Subject: libnetgraph4: netgraph completely broken
Message-ID: <[email protected]>
X-Mailer: reportbug 4.12.1
Date: Sun, 09 May 2010 20:11:33 -0400
Delivered-To: [email protected]

Package: libnetgraph4
Version: 8.0-4
Severity: grave
Justification: renders package unusable

I can't get netgraph to work under Debian/kFreeBSD. I was able to get 
ngctl to compile using a simple hack to work around #522773 and #522774
(#define __unused) but it's completely refusing to start:

loony:/home/anarcat/src/ngctl-7.3# ./ngctl  -d
ngctl: bind(ngctl3745): Invalid argument
ngctl: can't create node: Invalid argument

The kernel then spawns the following:

WARNING: attempt to net_add_domain(netgraph) after domainfinalize()

... regardless of whether I'm using the 7.2, 7.3 or 8.0 kernels. This
error happens only once, when the netgraph modules get autoloaded.

I'm also having problems making the PPPoE support of the ppp userland
program work, a related problem described here:

http://lists.debian.org/debian-bsd/2010/05/msg00017.html

(Note that I have also tried the ppp binary provided by the
freebsd-hackedutils package, which leads to a similar problem:

http://lists.debian.org/debian-bsd/2010/05/msg00019.html )

So my current guess the problem lies within the netgraph library (as
opposed to ngctl, ppp or the kernel), which would do some things in the
wrong order for the kernel. I'm really just guessing here but that's
what the error message error above says. :) (Then again, the above error
message signals an error *within* the kernel's internal API, so the
problem may also lie within the kernel.)

This blocks kfreebsd users from doing anything significant with the
library, so I'm marking this bug as grave. Furthermore, it's affecting
the ppp functionality (keeps PPPoE from working) so it could even be
upgraded to critical (if we want PPPoE in kfreebsd!!), but I'll let the
package maintainer decide this.

I hope this is clear enough and that my tests were complete enough. :)
Let me know if you can reproduce.

A.

(More debugging/tracing guesswork below, skip if you already know how to
fix this. :P)

(net_add_domain() is how new protocols register "hooks" (like protocol
families and hooks for connect() and bind() syscalls) within the kernel.
This is defined in sys/domain.h and kern/uipc_domain.c which make me
suspect the problem may also lie within...)

(I have also traced the problem within ngctl, libgraph and the netgraph
kernel module source code. The problem starts on the NgMkSockNode(3)
call in ngctl's main.c:174. That function, part of libnetgraph, goes
around creating the netgraph socket(2) and bind(2) (in sock.c:76) The
above debugging output shows that it's during the bind(2) (sock.c:104)
that the failure happens. The function registered to handle bind(2)
syscalls in netgraph is ngc_bind() (according to ng_socket.c:1049). From
there on there are multiple places that throw the EINVAL error we can
see in the following trace of ngctl:

6034 ngctl    CALL  socket(PF_NETGRAPH,SOCK_DGRAM,0x2)
6034 ngctl    RET   socket 3
6034 ngctl    CALL  bind(0x3,0xbfbfe2a0,0)
6034 ngctl    RET   bind -1 errno 22 Invalid argument

That's about as far I can trace this at this point.)

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: kfreebsd-i386 (i686)

Kernel: kFreeBSD 7.3-1-686
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to fr_CA.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libnetgraph4 depends on:
ii  libbsd0                       0.2.0-1    utility functions from BSD systems
ii  libc0.1                       2.10.2-7   Embedded GNU C Library: Shared lib

libnetgraph4 recommends no packages.

libnetgraph4 suggests no packages.

-- no debconf information



------------=_1722019533-2350120-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 580949-done) by bugs.debian.org; 26 Jul 2024 18:40:53 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
	(2021-04-09) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-108.0 required=4.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HAS_BUG_NUMBER,RCVD_IN_DNSWL_MED,
	SPF_HELO_PASS,SPF_NONE,USER_IN_DKIM_WELCOMELIST,USER_IN_DKIM_WHITELIST,
	VERSION autolearn=ham autolearn_force=no
	version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 14; hammy, 142; neutral, 39; spammy,
	0. spammytokens: hammytokens:0.000-+--HX-Debian:DAK,
	0.000-+--H*rp:D*ftp-master.debian.org, 0.000-+--H*r:sk:fasolo.,
	0.000-+--Hx-spam-relays-external:sk:fasolo., 0.000-+--H*RU:sk:fasolo.
Return-path: <[email protected]>
Received: from mitropoulos.debian.org ([2001:648:2ffc:deb:216:61ff:fe9d:958d]:47030)
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=mitropoulos.debian.org,[email protected] (verified)
	by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPs4-009qin-CF; Fri, 26 Jul 2024 18:40:53 +0000
Received: from [192.91.235.231] (port=55358 helo=fasolo.debian.org)
	from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=fasolo.debian.org,[email protected] (verified)
	by mitropoulos.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
	(Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPs3-00Ao5m-C1; Fri, 26 Jul 2024 18:40:50 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=ftp-master.debian.org; s=smtpauto.fasolo; h=Date:Message-Id:
	Content-Transfer-Encoding:Content-Type:Subject:MIME-Version:Cc:To:From:
	Reply-To:Content-ID:Content-Description:In-Reply-To:References;
	bh=xxU8DNDxjzwU3g4We2+tRgXbc243OJ68OcmWP4ggXoc=; b=GKobvVw0BI52IJs+uLjrziVQ+Z
	6a6GlliYekFUIkQ+uEjOaYZ5XYrIz2VW4hkx+Yi6qkRKgHCEQ+FLdyhRb3uIMGnlCq9oXPZO60yFC
	NmHvNqJkmn68AeRmAAf1plfHg9hh4dxLa2rm78qxiS6h098iVX+laPygqcc/1Xid/DdddbcJ4mvmi
	/quAEwo4dqCuRjriMzabutoU1QU0rGHOCPDIDuk3dfcWYMg6Wj65ob3CuHMQ3QOOf8eEivfjLn24R
	duuOfjCaBwiqPuW9JtxRkI8jGPVS25JDJJIxa/oZFD1tnj0P0wvGjQRA3MFytn9l3Z0XsIVKwDar3
	Yjp10YYQ==;
Received: from kitterman by fasolo.debian.org with local (Exim 4.94.2)
	(envelope-from <[email protected]>)
	id 1sXPs0-005bHw-Hn; Fri, 26 Jul 2024 18:40:48 +0000
From: Debian FTP Masters <[email protected]>
To: [email protected],[email protected],[email protected],[email protected],
X-DAK: dak rm
Cc: [email protected]
X-Filler: 42
X-Debian: DAK
Debian: DAK
MIME-Version: 1.0
Subject: Bug#1072229: Removed package(s) from unstable
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <[email protected]>
Date: Fri, 26 Jul 2024 18:40:48 +0000
X-CrossAssassin-Score: 2

Version: 10.3~svn296373-10+rm

Dear submitter,

as the package freebsd-libs has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1072229

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)
------------=_1722019533-2350120-0--