Re: Post 0.6.31 API changes
Pawel Kot <[email protected]> Mon, 13 Jan 2020 17:02:54 +0100
| Newsgroups | gmane.linux.drivers.gnokii |
|---|---|
| Message-ID | <CAHytCw7AhtPiqZ2XR9M-DR3rAwOt+YSMgor+BrhO0owh5H8Okw@mail.gmail.com> |
--===============7228737824277602393== Content-Type: multipart/alternative; boundary="0000000000005ecc19059c079c0b" --0000000000005ecc19059c079c0b Content-Type: text/plain; charset="UTF-8" Hi Ladis, On Sat, Jan 4, 2020 at 2:25 PM Ladislav Michl <[email protected]> wrote: > as 6d59b8b1a0f9 ("Move callbacks from gn_data to gn_statemachine->callbacks") > breaks API, we sould probably indicate that in libary version. True that. I believe that in the past I have been updating libgnokii version just before doing the release. > Looking to the history, commit 18de817d4958 ("Prepare 0.6.31 release") even > decreased GNOKII_LT_VERSION_AGE, so I'm unsure how is libgnokii meant to > handle API/ABI changes. I believe 0.6.31 did: # - If binary compatibility has been broken (eg removed or changed interfaces) # change to C-A+1:0:0 i.e. 7.0.1 -> (7-1+1):0:0 -> 7:0:0 WIth 0.6.32 we'd change to 8:0:0 > I'd like to resurrect GNOME Phone Manager, so something like this is needed: > https://github.com/3x380V/phonemgr/commit/5b35631c7242 > Eventually I can just require next gnokii version once (if at all) released. Given the gap between versions, I would depend on the next gnokii version to simplify the code. > Side question: libgnokii now depends on glib just to support locales in > gn_sms_send - it uses g_locale_to_utf8 which makes library behavior dependent > on current locale. Should we change to utf8 here? That's a good question. I'm in favor of simplifying but what is the practice for using gnokii these days? If someone is still reading this mailing list and still using gnokii, can you say if you're now fully on utf8 or are the some other locales being used? Having long break I'm now trying to restore my workflows and refresh git usage in some limited time boxes - sorry that it takes more than it should. Cheers, -- Pawel Kot --0000000000005ecc19059c079c0b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi Ladis,<br><br>On Sat, Jan 4, 2020 at 2:25 PM Ladislav M= ichl <<a href=3D"mailto:[email protected]">[email protected]</a>&g= t; wrote:<br>> as 6d59b8b1a0f9 ("Move callbacks from gn_data to gn_= statemachine->callbacks")<br>> breaks API, we sould probably ind= icate that in libary version.<div><br></div><div>True that. I believe that = in the past I have been updating libgnokii version just before doing the re= lease.</div><div><br></div><div>> Looking to the history, commit 18de817= d4958 ("Prepare 0.6.31 release") even<br>> decreased GNOKII_LT= _VERSION_AGE, so I'm unsure how is libgnokii meant to<br>> handle AP= I/ABI changes.<br><br>I believe 0.6.31 did:</div><div># - If binary compati= bility has been broken (eg removed or changed interfaces)<br># change to C-= A+1:0:0</div><div>i.e. 7.0.1 -> (7-1+1):0:0 -> 7:0:0</div><div>WIth 0= .6.32 we'd change to 8:0:0</div><div><br></div><div><table class=3D"gma= il-highlight gmail-tab-size gmail-js-file-line-container" style=3D"box-sizi= ng:border-box;border-spacing:0px;border-collapse:collapse;color:rgb(36,41,4= 6);font-family:-apple-system,system-ui,"Segoe UI",Helvetica,Arial= ,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-s= ize:14px"><tbody style=3D"box-sizing:border-box"></tbody></table>> I'= ;d like to resurrect GNOME Phone Manager, so something like this is needed:= <br>> <a href=3D"https://github.com/3x380V/phonemgr/commit/5b35631c7242"= >https://github.com/3x380V/phonemgr/commit/5b35631c7242</a><br>> Eventua= lly I can just require next gnokii version once (if at all) released.<br><b= r>Given the=C2=A0gap between versions, I would depend on the next gnokii ve= rsion to simplify the code.</div><div><br>> Side question: libgnokii now= depends on glib just to support locales in<br>> gn_sms_send - it uses g= _locale_to_utf8 which makes library behavior dependent<br>> on current l= ocale. Should we change to utf8 here?<br><br>That's a good question. I&= #39;m in favor of simplifying but what is the practice for using gnokii the= se days? If someone is still reading this mailing list and still using gnok= ii, can you say if you're now fully on utf8 or are the some other local= es being used?<br><br>Having long break I'm now trying to restore my wo= rkflows and refresh git usage in some limited time boxes - sorry that it ta= kes more than it should.</div><div><br>Cheers,</div><div>--<br>Pawel Kot</d= iv></div> --0000000000005ecc19059c079c0b-- --===============7228737824277602393== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZ25va2lpLXVz ZXJzIG1haWxpbmcgbGlzdApnbm9raWktdXNlcnNAbm9uZ251Lm9yZwpodHRwczovL2xpc3RzLm5v bmdudS5vcmcvbWFpbG1hbi9saXN0aW5mby9nbm9raWktdXNlcnMK --===============7228737824277602393==--