Re: [PATCH v2 1/8] Use the native autoconf support for cross-compilation
Pawel Kot <[email protected]> Mon, 13 Jan 2020 19:37:02 +0100
| Newsgroups | gmane.linux.drivers.gnokii |
|---|---|
| Message-ID | <CAHytCw4J6H9j1ac7vSZvu3QPcs=zmDFhZa0bKdZFT--fdFukfw@mail.gmail.com> |
--===============6093447468227792817== Content-Type: multipart/alternative; boundary="000000000000963bd2059c09c33c" --000000000000963bd2059c09c33c Content-Type: text/plain; charset="UTF-8" Hi, Not sure how should I do github reviews (cannot see options to comment on particular patches), so there go some comments. On Tue, Dec 4, 2018 at 10:20 PM Ladislav Michl <[email protected]> wrote: > > From: Fabrizio Gennari <[email protected]> > > Remove homebrew --enable-win option and use the standard autoconf way > to cross-compile, that is using option --host. In general it is OK, but some pieces do not belong here I think. > - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then > + if test "$enable_bluetooth" = "yes"; then [...] > - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then > + if test "$enable_bluetooth" = "yes"; then [...] > -AM_CONDITIONAL([FOR_MAC], [test x$ac_cv_have_iobluetooth = xyes]) > + FOR_MAC=1 [...] > - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then > + if test "$enable_bluetooth" = "yes"; then [...] > - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then > + if test "$enable_bluetooth" = "yes"; then [...] These seem to be unrelated. And even not sure why they are there? Also not sure why FOR_MAC would be dependent on iobluetooth. Cheers, -- Pawel Kot --000000000000963bd2059c09c33c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi,<div><br></div><div>Not sure how should I do github rev= iews (cannot see options to comment on particular patches), so there go som= e comments.<br><br>On Tue, Dec 4, 2018 at 10:20 PM Ladislav Michl <<a hr= ef=3D"mailto:[email protected]">[email protected]</a>> wrote:<br>&= gt;<br>> From: Fabrizio Gennari <<a href=3D"mailto:fabrizio.ge@tiscal= i.it">[email protected]</a>><br>><br>> Remove homebrew --enab= le-win option and use the standard autoconf way<br>> to cross-compile, t= hat is using option --host.</div><div><br></div><div>In general it is OK, b= ut some pieces do not belong here I think.</div><div><br>> - =C2=A0 =C2= =A0 =C2=A0 if test "$enable_bluetooth" =3D "yes" -a &qu= ot;$USE_BLUETOOTH" =3D "no"; then<br>> + =C2=A0 =C2=A0 = =C2=A0 if test "$enable_bluetooth" =3D "yes"; then</div= ><div>[...]</div><div>> - =C2=A0 =C2=A0 =C2=A0 if test "$enable_blu= etooth" =3D "yes" -a "$USE_BLUETOOTH" =3D "no= "; then<br></div><div>> + =C2=A0 =C2=A0 =C2=A0 if test "$enabl= e_bluetooth" =3D "yes"; then</div><div>[...]<br>> -AM_CON= DITIONAL([FOR_MAC], [test x$ac_cv_have_iobluetooth =3D xyes])<br>> + =C2= =A0 =C2=A0 =C2=A0 FOR_MAC=3D1</div><div>[...]<br>> - =C2=A0 =C2=A0 =C2= =A0 if test "$enable_bluetooth" =3D "yes" -a "$USE= _BLUETOOTH" =3D "no"; then<br>> + =C2=A0 =C2=A0 =C2=A0 if= test "$enable_bluetooth" =3D "yes"; then</div><div>[..= .]<br>> - =C2=A0 =C2=A0 =C2=A0 if test "$enable_bluetooth" =3D= "yes" -a "$USE_BLUETOOTH" =3D "no"; then<br>= > + =C2=A0 =C2=A0 =C2=A0 if test "$enable_bluetooth" =3D "= ;yes"; then</div><div>[...]<br><br>These seem to be unrelated. And eve= n not sure why they are there? Also not sure why FOR_MAC would be dependent= on iobluetooth.<br><br>Cheers,</div><div>--<br>Pawel Kot</div></div> --000000000000963bd2059c09c33c-- --===============6093447468227792817== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZ25va2lpLXVz ZXJzIG1haWxpbmcgbGlzdApnbm9raWktdXNlcnNAbm9uZ251Lm9yZwpodHRwczovL2xpc3RzLm5v bmdudS5vcmcvbWFpbG1hbi9saXN0aW5mby9nbm9raWktdXNlcnMK --===============6093447468227792817==--