Re: [PATCH 2/9] supplicant: Allow user-defined defaults for Interworking network blocks.

On 02/16/2020 05:51 AM, Jouni Malinen wrote:
> On Fri, Feb 07, 2020 at 01:10:10AM -0800, [email protected] wrote:
>> This way users can still configure the HT over-rides and some other
>> constraints that Interworking has no interest or ability to configure.
>
> What's the use case for this?

My purpose is for testing, not sure there is any use case for normal
users.

>
>> diff --git a/src/utils/common.c b/src/utils/common.c
>> @@ -891,6 +891,9 @@ void int_array_concat(int **res, const int *a)
>>   	reslen = int_array_len(*res);
>>   	alen = int_array_len(a);
>>
>> +	if (alen == 0)
>> +		return; /* nothing to concat */
>
> How is this related to this commit? Is that just to optimize
> int_array_concat() not to require realloc? In any case, it should be in
> a separate commit.

Probably was just an optimization, I think I had issues with concatting things
when writing this patch and added that code while debugging.  I'll split it
into a separate patch.

>
>> diff --git a/wpa_supplicant/config_ssid.h b/wpa_supplicant/config_ssid.h
>> @@ -642,6 +643,12 @@ struct wpa_ssid {
>> +	/**
>> +	 * interworking_defaults - Whether this network block should be used for
>> +	 *    network defaults when creating temporary interworking network blocks.
>> +	 */
>> +	int interworking_defaults;
>
> This looks a bit inconvenient and misleading.. There could be multiple
> networks with interworking_defaults=1. And even worse, these network
> blocks could be used for a connection on their own. Special cases like
> this for network blocks have been used with new values assigned to the
> disabled parameter which has the benefit of automatically disabling the
> network blocks from normal network selection. For example, disabled=2 is
> used for P2P persistent group parameters.

Ok, so I'd have disabled=3 mean 'interworking-defaults'?

>
>> diff --git a/wpa_supplicant/scan.h b/wpa_supplicant/scan.h
>> @@ -86,5 +86,6 @@ unsigned int wpas_get_est_tpt(const struct wpa_supplicant *wpa_s,
>>   			      const u8 *ies, size_t ies_len, int rate,
>>   			      int snr);
>>   void wpa_supplicant_set_default_scan_ies(struct wpa_supplicant *wpa_s);
>> +void int_array_concat(int **res, const int *a);
>
> Why? That function is in src/utils/common.c and the prototype for it is
> already in src/utils/common.h.

Not sure why I did this, I can retest the build w/out it.


Thanks,
Ben

-- 
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com