Re: [PATCH] eapol_test build under GCC-10

Roy Marples <[email protected]>
Newsgroups gmane.linux.drivers.hostap
Message-ID <[email protected]>
On 16/02/2020 15:23, Didier 'OdyX' Raboud wrote:
> eapol_test.c: In function ‘main’:
> eapol_test.c:1393:11: error: unknown conversion type character ‘+’ in format [-Werror=format=]
>   1393 |    printf("eapol_test v" VERSION_STR "\n");
>        |           ^~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> It might be because in the Debian package's development case, VERSION_STR
> ends up being "v2.10-devel-debian/2%2.9+git20200213+877d9a0-1-3-g3bd59207c+".

I'm tempted to say this is a Debian bug because it's their fault.

On the other hand, if more downstreams do this then we should treat VERSION_STR 
as un-sanitized input which make passing it in as the argument to %s valid.

Roy

_______________________________________________
Hostap mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/hostap
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.