Re: [PATCH] Extend set_key() parameters in struct to all users

On Fri, Jan 10, 2020 at 12:04:59AM +0100, Alexander Wetzel wrote:
> Extend the set_key() parameters struct beyond only the driver API.
> This makes it very trivial to add/use new parameters for set_key()
> nearly anywhere in the code.

> This is the "extended" version of converting set_key() funktions to a
> parameter struct. Instead of translating the new params to the old
> function parameter names I switched more or less everything to params.
> This is of course changing quite some code but using only pretty simple
> transformations. It has some drive-by fixes and unifications:

This does not look like a change that would make it easier to read the
code or maintain this, so unless there is a clear benefit that I've
missed, I think I'd rather not apply most of these changes.

>  - And I think you forgot passing through the key_flag in the privsep
>    driver

However, this is clearly something that should be done. I applied these
changes. Thanks.

-- 
Jouni Malinen                                            PGP id EFC895FA