Re: [PATCH] p2p: Set MAC address of P2P device interface via vendor command

On 4/6/2020 9:01 PM, Johannes Berg wrote:
> On Mon, 2020-04-06 at 11:21 -0700, Stephen Chu wrote:
>>  From 7b0357dd90f9b5974779743078b3b482c98dc18b Mon Sep 17 00:00:00 2001
>> From: Stephen Chu <[email protected]>
>> Date: Mon, 6 Apr 2020 11:13:49 -0700
>> Subject: [PATCH] p2p: Set MAC address of P2P device interface via vendor
>>   command
>>
>> Supplicant uses standard linux IOCTL for setting the mac addr.  However,
>> P2P device interface is a netless interface and hence this case needs
>> additional handling.  The supplicant could pass down the mac address to be
>> configured via vendor command to the wireless driver.  From this context,
>> the wireless driver can update the p2p discovery address via iovar.
> 
> If the driver already supports nl80211, why doesn't it support a
> P2P_DEVICE wdev, where the address could be set?
> 
> Or is it that we can only set it when *creating* that, and somehow the
> driver has it pre-created?

I would say that pre-creation could be hidden by the wireless driver 
although I am not sure why it could not deal with P2P_DEV wdev.

The introduced vendor-specific header file introduces a whole lot more 
primitives. I think you should trim down this file and only have the 
"set mac address" primitive although even that one is arguable.

Regards,
Arend