Re: [PATCH 2/3] ubifs: key.h: use correct function parameter name

Zhihao Cheng <[email protected]> Thu, 30 Jul 2026 09:20:35 +0800
Newsgroups gmane.linux.kernel,gmane.linux.drivers.mtd
Message-ID <[email protected]>
在 2026/7/30 1:20, Randy Dunlap 写道:
> Use @hash as the function parameter name to prevent kernel-doc warnings:
> 
> Warning: fs/ubifs/key.h:42 function parameter 'hash' not described in 'key_mask_hash'
> Warning: fs/ubifs/key.h:42 Excess function parameter 'val' description in 'key_mask_hash'
> 
> Signed-off-by: Randy Dunlap <[email protected]>
> ---
> Cc: Richard Weinberger <[email protected]>
> Cc: Zhihao Cheng <[email protected]>
> Cc: [email protected]
> 
>   fs/ubifs/key.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Zhihao Cheng <[email protected]>
> 
> --- linux-next-20260729.orig/fs/ubifs/key.h
> +++ linux-next-20260729/fs/ubifs/key.h
> @@ -33,7 +33,7 @@
>   
>   /**
>    * key_mask_hash - mask a valid hash value.
> - * @val: value to be masked
> + * @hash: value to be masked
>    *
>    * We use hash values as offset in directories, so values %0 and %1 are
>    * reserved for "." and "..". %2 is reserved for "end of readdir" marker. This
> .
>