Re: Re: Closing enbd devices

"Also sprach Dag Sverre Seljebotn:"
> wanted to inform you about the quality (testedness) of the patch, so
> that you (as maintainer of the source) could make a decision about
> including the patch in the next enbd release or not. I don't know what

Well, I tried the "reset" thing and it seems to work. Everything went
back to "Closed" again in the nbdinfo display! Cute.

But I was using 2.6 and it may be different for you on 2.4.  On 2.6 the
driver has the device structs as permanent static memory (:-() because
of the way 2.6 does device registrations.  So it seems to use a weaker
condition that "existence" to decide if the device is "Closed" or not.
Yes, it's

    lo->nslot <= 0

whereas in 2.4 it is

    !lo || lo->nslot <= 0

nslot is incremented by a successful connect and never decremented, so
closed means usually "never opened yet". nslot is the max number of
clients seen running.

> quality standards you operate by. I did not want you to test it for me

You'll have to do the testing anyway.  I really am very wary of closing
things :).


Peter