Re: [PATCH] cfbimgblt: Allow generic BitBLT functions to work with swapped pixel order in bytes.

On Sun, 2007-09-02 at 02:58 +0200, Pavel Pisa wrote:
> On Sunday 02 September 2007 02:36, Antonino A. Daplas wrote:
> > On Sat, 2007-09-01 at 15:47 +0200, Pavel Pisa wrote:
> > > On Friday 31 August 2007 13:03, Antonino A. Daplas wrote:
> > >
> > > @@ -348,6 +357,7 @@ config FB_IMX
> > >  	select FB_CFB_FILLRECT
> > >  	select FB_CFB_COPYAREA
> > >  	select FB_CFB_IMAGEBLIT
> > > +	select FB_CFB_REV_PIXELS_IN_BYTE
> > >
> > >  config FB_CYBER2000
> > >  	tristate "CyberPro 2000/2010/5000 support"
> >
> > BTW, I'll submit this hunk as a separate patch, so it's clearer that
> > imxfb is the one particular driver that needs this change.
> 
> Hello Tony,
> 
> in the fact, this line is not necessary at all. If "imxfb"
> is used with color display or TFT, then it is not required.
> Omit this change from the patch. It could be moved into
> "imxfb-nonstd-info.patch" patch, but it is not necessary.
> 

Now you're confusing me. If you don't enable
CONFIG_FB_CFB_REV_PIXELS_IN_BYTE, then the byte-swapping code does not
get compiled, yes?

> http://rtime.felk.cvut.cz/repos/ppisa-linux-devel/kernel-patches/current/imxfb-nonstd-info.patch
> 
> I suggest to keep the next two as separate
>   cfb-pixels-in-byte-swapped.patch
>   cfb-copyarea-swapping.patch
> 
> Would you take latest version from my repository
> or should I resend them inline?

Well, I still need your changelog and Signed-off-by: line for the
imxfb-nonstd-info.patch.  I can get the other 2 from your repository
though.

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/