Re: [PATCH] cfbimgblt: Allow generic BitBLT functions to work with swapped pixel order in bytes.

On Sunday 02 September 2007 05:34, Antonino A. Daplas wrote:
> On Sun, 2007-09-02 at 02:58 +0200, Pavel Pisa wrote:
> > On Sunday 02 September 2007 02:36, Antonino A. Daplas wrote:
> > > On Sat, 2007-09-01 at 15:47 +0200, Pavel Pisa wrote:
> > > > On Friday 31 August 2007 13:03, Antonino A. Daplas wrote:
> > > >
> > > > @@ -348,6 +357,7 @@ config FB_IMX
> > > >  	select FB_CFB_FILLRECT
> > > >  	select FB_CFB_COPYAREA
> > > >  	select FB_CFB_IMAGEBLIT
> > > > +	select FB_CFB_REV_PIXELS_IN_BYTE
> > > >
> > > >  config FB_CYBER2000
> > > >  	tristate "CyberPro 2000/2010/5000 support"
> > >
> > > BTW, I'll submit this hunk as a separate patch, so it's clearer that
> > > imxfb is the one particular driver that needs this change.
> >
> > Hello Tony,
> >
> > in the fact, this line is not necessary at all. If "imxfb"
> > is used with color display or TFT, then it is not required.
> > Omit this change from the patch. It could be moved into
> > "imxfb-nonstd-info.patch" patch, but it is not necessary.
>
> Now you're confusing me. If you don't enable
> CONFIG_FB_CFB_REV_PIXELS_IN_BYTE, then the byte-swapping code does not
> get compiled, yes?

Hello Tony,

I have not worded it cleanly, sorry.

The swapping is necessary for 4-bit gray scale levels or 4-bit
color palette modes for i.MX/MX1 framebuffer driver.
But if the kernel is compiled for MX1 board/application, where these
modes are not used, then it is not necessary to compile swapping
support into kernel. It does not harm hand but it causes some
overhead. The selection of CONFIG_FB_CFB_REV_PIXELS_IN_BYTE
can be left on user or board configuration. It does not need to
be forced by select and I agree, that this line does not belong to
generic part of changes.

> Well, I still need your changelog and Signed-off-by: line for the
> imxfb-nonstd-info.patch.  I can get the other 2 from your repository
> though.

As for "imxfb-nonstd-info.patch", I add changelog for sure. But
before inclusion it should go through linux-arm-kernel mailinglist and
should be reviewed by Sascha Hauer. I would send it there
with CC to you. Please, inform me, if it should go through ARM patch
system or over your queue then.

Thanks again

             Pavel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/