Re: [PATCH] cfbimgblt: Allow generic BitBLT functions to work with swapped pixel order in bytes.

On Sun, 2007-09-02 at 11:46 +0200, Pavel Pisa wrote:
> On Sunday 02 September 2007 05:34, Antonino A. Daplas wrote:
> > On Sun, 2007-09-02 at 02:58 +0200, Pavel Pisa wrote:
> > > On Sunday 02 September 2007 02:36, Antonino A. Daplas wrote:
> > > > On Sat, 2007-09-01 at 15:47 +0200, Pavel Pisa wrote:
> > > > > On Friday 31 August 2007 13:03, Antonino A. Daplas wrote:
> > > > >

> 
> The swapping is necessary for 4-bit gray scale levels or 4-bit
> color palette modes for i.MX/MX1 framebuffer driver.
> But if the kernel is compiled for MX1 board/application, where these
> modes are not used, then it is not necessary to compile swapping
> support into kernel. It does not harm hand but it causes some
> overhead. The selection of CONFIG_FB_CFB_REV_PIXELS_IN_BYTE
> can be left on user or board configuration. It does not need to
> be forced by select and I agree, that this line does not belong to
> generic part of changes.

Understood. Although someone might comment that I'm including a feature
without a driver depending on it. I'll just clarify this in the
changelog.

> 
> > Well, I still need your changelog and Signed-off-by: line for the
> > imxfb-nonstd-info.patch.  I can get the other 2 from your repository
> > though.
> 
> As for "imxfb-nonstd-info.patch", I add changelog for sure. But
> before inclusion it should go through linux-arm-kernel mailinglist and
> should be reviewed by Sascha Hauer. I would send it there
> with CC to you. Please, inform me, if it should go through ARM patch
> system or over your queue then.

I don't mind you submitting your changes to the linux-arm mailing list
and Sascha first. Sascha can channel it through me or directly to
mainline later. 

I'll just pick up the 2 patches then. 

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/