Re: [ANNOUNCE] new HFS(+) driver

On 10.03, Roman Zippel wrote:
> Hi,
> 
> On Fri, 3 Oct 2003, J.A. Magallon wrote:
> 
> > Two notes:
> > - You should give a patch or at least give a notice that linux/include/hfs* have
> >   to be killed (or move hfs_fs.h there).
> 
> You did apply linux-2.4.hfs.diff? I don't understand why you had to move 
> hfs_fs.h, it should be picked up from the current directory.
> 

I applied it, it just keeps mainstream files from including old hfs* files
in include/linux, but the old files stay around (you end with two
versions of hfs_fs.h, one in include/linux and other in fs/hfs...)
I did not move anything, just deleted those old files. But as other
filesystems put their xxxx_fs.h in include/linux, I thought that
perhaps hfs(plus) should do the same.

> > - I had to include linux/sched.h in hfs/sysdep.c to get the definition for
> >   'current', that was neded in some subinclude of linux/smp_lock. This can be
> >   caused by any other of my patches, but it doesn't hurt.
> 
> Simply move <linux/smp_lock.h> past "hfs_fs.h".
> 

Thanks.

-- 
J.A. Magallon <jamagallon()able!es>     \                 Software is like sex:
werewolf!able!es                         \           It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.23-pre6-jam1 (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk))


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf