Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Christoph Hellwig <[email protected]> Tue, 7 Aug 2007 21:51:49 +0100
| Newsgroups | gmane.linux.cluster.redhat.cluster.devel,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.reiserfs.general,gmane.linux.kernel,gmane.comp.file-systems.fuse.devel,gmane.linux.file-systems.jffs,gmane.linux.uml.user,gmane.linux.file-systems,gmane.comp.file-systems.ext4,gmane.linux.file-systems.cifs,gmane.comp.file-systems.ocfs2.devel |
|---|---|
| Message-ID | <[email protected]> |
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr) This function badly needs a kerneldoc description. Also I can't say I like the name a lot, but without a clearly better idea I should probably not complain :) We should at least add a generic_ prefix to indicate it's a generic helper valid for most filesystem (and the kerneldoc comment can explain the details)