Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

Jeff Layton <[email protected]> Tue, 7 Aug 2007 18:13:49 -0400

Newsgroups	gmane.linux.cluster.redhat.cluster.devel,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.reiserfs.general,gmane.linux.kernel,gmane.comp.file-systems.fuse.devel,gmane.linux.file-systems.jffs,gmane.linux.uml.user,gmane.linux.file-systems,gmane.comp.file-systems.ext4,gmane.linux.file-systems.cifs,gmane.comp.file-systems.ocfs2.devel
Message-ID	<[email protected]>

On Tue, 7 Aug 2007 21:49:09 +0100
Christoph Hellwig <[email protected]> wrote:

> First thanks a lot for doing this work, it's been long needed.
> 
> Second please don't send out that many patches.  We encourage people
> to split things into small patches when the changes are logially
> separated.  Which these are not - it's a flag day change (which btw
> is fine despite the rants soe people spewed in reply to this), so it
> should be one single patch. (Or one for all mainline filesystems +
> one per fs only in -mm to make Andrew's life a little easier if you
> really care.)

Thanks. I debated about how best to split these up. A coworker
mentioned that Andrew had tossed him back a single patch that
touched several mainline filesystems and asked him to break it 
up. I took that to mean that the patches should generally be split
out, but I guess I took that too far ;-)

-- 
Jeff Layton <[email protected]>