Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)

David Woodhouse <[email protected]> Sun, 21 Oct 2007 09:55:44 +0100
Newsgroups gmane.linux.drivers.mtd,gmane.linux.kernel,gmane.linux.file-systems.jffs
Message-ID <[email protected]>
On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
> 
>         if (writtenlen) {
> -               if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen) {
> -                       inode->i_size = (pg->index << PAGE_CACHE_SHIFT) + start + writtenlen;
> +               if (inode->i_size < pos + start + writtenlen) {
> +                       inode->i_size = pos + start + writtenlen;

This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start

-- 
dwmw2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/