Re: BUG at mm/filemap.c:1749 (2.6.24, jffs2, unionfs)

Nick Piggin <[email protected]> Sun, 21 Oct 2007 19:57:11 +1000

Newsgroups	gmane.linux.kernel,gmane.linux.file-systems.jffs,gmane.linux.drivers.mtd
Message-ID	<[email protected]>

On Sunday 21 October 2007 18:55, David Woodhouse wrote:
> On Fri, 2007-10-19 at 17:16 +1000, Nick Piggin wrote:
> >         if (writtenlen) {
> > -               if (inode->i_size < (pg->index << PAGE_CACHE_SHIFT) +
> > start + writtenlen) { -                       inode->i_size = (pg->index
> > << PAGE_CACHE_SHIFT) + start + writtenlen; +               if
> > (inode->i_size < pos + start + writtenlen) {
> > +                       inode->i_size = pos + start + writtenlen;
>
> This part seems wrong. Shouldn't it just be pos + writtenlen -- which is
> basically what it was already: pos==(pg->index<<PAGE_CACHE_SHIFT)+start

Yeah you're right, thanks.