Re: [PATCH] install-qa-check.d/60cargo-eclass: make it a failure for EAPI>=9

Sam James <[email protected]>
Newsgroups gmane.linux.gentoo.devel
Organization Gentoo
Message-ID <[email protected]>
Arthur Zamarin <[email protected]> writes:

> While cargo.eclass doesn't yet support EAPI 9, I want to make it a
> failure for EAPI 9 ebuilds to be merged without the RUST_MIN_VER being
> updated to the correct value.
>
> The class itself supports currently EAPI=8, so this should be a safe
> change to make, and it will help ensure that the ebuilds are updated in
> a timely manner.
>
> Signed-off-by: Arthur Zamarin <[email protected]>
> ---
>  metadata/install-qa-check.d/60cargo-eclass | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/metadata/install-qa-check.d/60cargo-eclass b/metadata/install-qa-check.d/60cargo-eclass
> index 4fd014b2287..4147f85b768 100644
> --- a/metadata/install-qa-check.d/60cargo-eclass
> +++ b/metadata/install-qa-check.d/60cargo-eclass
> @@ -42,6 +42,9 @@ cargo_ver_check() {
>  		eqawarn "QA Notice: ${min_rust_source}"
>  		eqawarn "which requires RUST_MIN_VER=\"${min_rust_ver}\""
>  		eqawarn
> +
> +		# For EAPI>=9, enforce the ebuild being updated to specify the correct RUST_MIN_VER
> +		[[ ${EAPI} = 8]] || die "Update ebuild to specify RUST_MIN_VER=\"${min_rust_ver}\""

8 ]]

OK with that fixed.

>  	fi
>  }
signature.asc (application/pgp-signature, 418 B)
-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmn1n2MbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkAK7
AQDK4FFJSgS6MrKuBTBhe/izrDlfgk48S4xG3Iw84wtRfAD/TzO5yOMvIlo4MjTk
jD/qWDkMNVKSyiKtvAXN/0HjgQA=
=KG1e
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.