Re: [PATCH] install-qa-check.d/60cargo-eclass: make it a failure for EAPI>=9

On Sat, 2026-05-02 at 09:43 +0300, Arthur Zamarin wrote:
> While cargo.eclass doesn't yet support EAPI 9, I want to make it a
> failure for EAPI 9 ebuilds to be merged without the RUST_MIN_VER being
> updated to the correct value.
> 
> The class itself supports currently EAPI=8, so this should be a safe
> change to make, and it will help ensure that the ebuilds are updated in
> a timely manner.
> 
> Signed-off-by: Arthur Zamarin <[email protected]>
> ---
>  metadata/install-qa-check.d/60cargo-eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/metadata/install-qa-check.d/60cargo-eclass b/metadata/install-qa-check.d/60cargo-eclass
> index 4fd014b2287..4147f85b768 100644
> --- a/metadata/install-qa-check.d/60cargo-eclass
> +++ b/metadata/install-qa-check.d/60cargo-eclass
> @@ -42,6 +42,9 @@ cargo_ver_check() {
>  		eqawarn "QA Notice: ${min_rust_source}"
>  		eqawarn "which requires RUST_MIN_VER=\"${min_rust_ver}\""
>  		eqawarn
> +
> +		# For EAPI>=9, enforce the ebuild being updated to specify the correct RUST_MIN_VER
> +		[[ ${EAPI} = 8]] || die "Update ebuild to specify RUST_MIN_VER=\"${min_rust_ver}\""

I personally find inverse logic hard to read, i.e. would prefer:

[[ ${EAPI} != 8 ]] && die ...

(read "if EAPI is not 8, then die")

>  	fi
>  }
>  

-- 
Best regards,
Michał Górny

-----BEGIN PGP SIGNATURE-----

iKQEABYKAEwWIQQcFD0bEK7NPNmWHtiOMjR69AVa6AUCafWg5hsUgAAAAAAEAA5t
YW51MiwyLjUrMS4xMiwyLDISHG1nb3JueUBnZW50b28ub3JnAAoJEI4yNHr0BVro
h9kA/j6KQdp0+XuoN7PXljwfrAw3f1h+XjdhzpnnkDbfCXILAQDINVo1zkHulqFu
NvLTZRRDOIctquAQuzhnjTv7u5ZmDQ==
=weIo
-----END PGP SIGNATURE-----