Re: [PATCH 1/9] esplit.eclass: add new eclass

--=-=-=
Content-Type: text/plain

>>>>> On Thu, 09 Jul 2026, Sam James wrote:

> +# }
> +#
> +# process_list

Add a blank line here, to separate the comment block from the following
unrelated code?

> +case ${EAPI} in
> +	8|9) ;;
> +	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> +esac
> +
> +if [[ -z ${_ESPLIT_ECLASS} ]] ; then
> +_ESPLIT_ECLASS=1

For such a simple eclass, the inherit guard may add more overhead than
it can potentially prevent. Maybe omit it? We have precendent with other
simple eclasses.

> +	local -

The "-" argument was introduced in Bash 4.4, so using it in EAPI 8 is
fine (it wouldn't be in EAPI 7).

Ulrich

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFfBAEBCABJFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmpQkV4bFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyDxx1bG1AZ2VudG9vLm9yZwAKCRBRiDNQiEFeLorV
B/93wTaXEbqOonpe630xfqSOWBiw4Z6zm+I19A0h5+M11OjhiN1A2AUsKult6WIW
RO3EcafSwcMJ7r7aeoMmsUoGi+EyRtePYj8E1qnS6078GktcVUm658Pns8xe9EPY
khXZTVYzzst4RgRauRMz+JWjWHd0xDCt6pMpWGR4G02yKg+2X2riqFQU7WPA1Zy7
O6ChExsWuK2ht08Ws5txT8HuVFxvH5y2oz9FG1V1TNUR6cXaOUkgkEmzxqCg5mzS
t0ZAj3ap+HgdiantwrF+2LC0nQJquyHmLhfzNxk52BMVnaAilMVU5nVtW0hvwlG8
uZNu7h3COpwyryaeE0YR0/SL
=H7mR
-----END PGP SIGNATURE-----
--=-=-=--