Re: [PATCH 6/9] kernel-2.eclass: port to esplit.eclass
Ulrich Müller <[email protected]> Fri, 10 Jul 2026 08:37:46 +0200
| Newsgroups | gmane.linux.gentoo.devel |
|---|---|
| Message-ID | <[email protected]> |
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
>>>>> On Thu, 09 Jul 2026, Sam James wrote:
> --- a/eclass/kernel-2.eclass
> +++ b/eclass/kernel-2.eclass
> @@ -792,7 +792,7 @@ universal_unpack() {
> debug-print "Inside universal_unpack"
>=20=20
> local OKV_ARRAY
> - local IFS=3D.; OKV_ARRAY=3D(${OKV}); unset IFS
> + mapfile -d '' OKV_ARRAY < <(IFS=3D. esplit "${OKV}")
TBH, I find the replacement code harder to understand than the original.
(Probably it is also less efficient?)
Also, what about the other instances of this line, and shouldn't
esplit.eclass be inherited?
>=20=20
> cd "${WORKDIR}" || die
> if [[ ${#OKV_ARRAY[@]} -ge 3 && ${KV_MAJOR} -ge 3 ]]; then
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQFfBAEBCABJFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmpQkzsbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyDxx1bG1AZ2VudG9vLm9yZwAKCRBRiDNQiEFeLlrh
B/9YTfwyj76pBri5a0wypKDZ+Y7WziR/R5feuGuzS8jegH6/LCh3Hl2t4gSwLS/h
UOJ7RneHkmvRntj5Bw65bo0YIzRm8+hJ5nY2ULHk/XrsL7mILbTpiPWdA7SR9l+0
PvztcTF/lztiBRsBROFgEvKHWjj/x1v08g5M5OVSzlihckmgl74U/SEDDFTJVunt
0nq1zABXNYhkPcNNU7YcPA+bW/Q9PA1EuZHXn4UUM5i+OdUMjtvE2HVzx9gmsJlD
oYgFHkqOrygpqbR1sMoz59FceqqZrPpYwQvTgx2kDBYQM1dt53bwBd2tnhHaP0eQ
BsgJTJCGt7zmzk04kjcTCBJ0
=0lP0
-----END PGP SIGNATURE-----
--=-=-=--