Re: [PATCH 08/10] nginx{,-module}.eclass: save NGINX build config by storing ./configure flags

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Peter Volkov <[email protected]> writes:

> Hi!
>
> On Sat, Jul 18, 2026 at 7:45=E2=80=AFPM Zurab Kvachadze <zurabid2016@gmai=
l.com> wrote:
>> +# @ECLASS_VARIABLE: _NGX_MOD_CONFIG_FLAGS_FILE
>> +# @INTERNAL
>> +# @DESCRIPTION:
>> +# Holds the path to the file containing NUL-separated ./configure flags=
 used to
>> +# build www-servers/nginx.
>> +_NGX_MOD_CONFIG_FLAGS_FILE=3D"${BROOT}/usr/src/nginx/configure-flags"
>
> Take a look at table 8.2 of PMS https://projects.gentoo.org/pms/latest/pm=
s.html.
> Eclass is referencing target build-time dependencies here; ESYSROOT is ex=
pected
> instead of BROOT.
>
> Since the variable is global, it would be better to store only the root-r=
elative path:
> _NGX_MOD_CONFIG_FLAGS_FILE=3D"/usr/src/nginx/configure-flags"
> Then prefix it with ESYSROOT in src_* phases, or with EROOT if it is ever=
 used in pkg_* phases.

Yes, sorry for missing that, I'd missed it when going over everything.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmpxLWMbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkFlv
AP9v8mrSU+0x5P7QjJRsRQcQm59ALBwmSWfQeE3e6OrAsAD9G6SIYbXPGGGDrAKW
Z17PQ5MQ6ZmqIDubdHrCT1Z+XwY=
=8w6p
-----END PGP SIGNATURE-----
--=-=-=--