Re: [PATCH 09/10] nginx-module.eclass: add ngx_force_module()

Peter Volkov <[email protected]> Tue, 4 Aug 2026 12:42:23 +0300
Newsgroups gmane.linux.gentoo.devel
Message-ID <CAE+k_g++GbNt0DjMTvYNw-2ny1JNGrxq1OCEa+FdZRYRo_3O-A@mail.gmail.com>
On Sat, Jul 18, 2026 at 7:46=E2=80=AFPM Zurab Kvachadze <zurabid2016@gmail.=
com> wrote:
> +_ngx_mod_enforce_module_flags() {
...
> +       # Check whether we already have the target_string or inverse_stri=
ng in
> +       # the specified flag variable.
> +       local key
> +       for key in "${!ref_target[@]}"; do
> +               case "${ref_target[${key}]}" in
> +                       "${target_string}")
> +                               return 0
> +                               ;;
> +                       "${inverse_string}")
> +                               unset 'ref_target[${key}]'
> +                               return 0
> +                               ;;

Maybe it would be a good idea to support --with-<mode>_module=3Ddynamic
format as well. It's possible to provide such an option through
EXTRA_ECONF.

case "${ref_target[${key}]}" in
  "${target_string}"|"${target_string}=3Ddynamic")
  return 0
  ;;
"${inverse_string}"|"${inverse_string}=3Ddynamic")
  unset 'ref_target[${key}]'
  return 0
  ;;
esac

> +       if [[ ${state} -ne 2 && ${state} -ne -2 ]]; then
> +               # Neither target_string, nor inverse_string are found in
> +               # ./configure --help: either the module genuinely does no=
t exist or
> +               # something has gone really wrong.
> +               die "ngx_force_module: module \"${mod}\" not found and '-=
n' has not been supplied"

Typo. '-t' is expected here.

--
Peter.