Re: [PATCH 09/10] nginx-module.eclass: add ngx_force_module()

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Peter Volkov <[email protected]> writes:

> On Sat, Jul 18, 2026 at 7:46=E2=80=AFPM Zurab Kvachadze <zurabid2016@gmai=
l.com> wrote:
>> +_ngx_mod_enforce_module_flags() {
> ...
>> +       # Check whether we already have the target_string or inverse_str=
ing in
>> +       # the specified flag variable.
>> +       local key
>> +       for key in "${!ref_target[@]}"; do
>> +               case "${ref_target[${key}]}" in
>> +                       "${target_string}")
>> +                               return 0
>> +                               ;;
>> +                       "${inverse_string}")
>> +                               unset 'ref_target[${key}]'
>> +                               return 0
>> +                               ;;
>
> Maybe it would be a good idea to support --with-<mode>_module=3Ddynamic
> format as well. It's possible to provide such an option through
> EXTRA_ECONF.

Why would that be specified in EXTRA_ECONF?

>
> case "${ref_target[${key}]}" in
>   "${target_string}"|"${target_string}=3Ddynamic")
>   return 0
>   ;;
> "${inverse_string}"|"${inverse_string}=3Ddynamic")
>   unset 'ref_target[${key}]'
>   return 0
>   ;;
> esac
>
>> +       if [[ ${state} -ne 2 && ${state} -ne -2 ]]; then
>> +               # Neither target_string, nor inverse_string are found in
>> +               # ./configure --help: either the module genuinely does n=
ot exist or
>> +               # something has gone really wrong.
>> +               die "ngx_force_module: module \"${mod}\" not found and '=
-n' has not been supplied"
>
> Typo. '-t' is expected here.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmpxzIobFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkI9/
AQDABUAgp/U2nVecLhi2bFiTGFF/ttp3AD/RmbzLKKIjrwD/cuztT6xRXPZWoVPq
0R5oh0EjALuVyrURSUTlU3daqQo=
=qBpw
-----END PGP SIGNATURE-----
--=-=-=--