Re: [PATCH 09/10] nginx-module.eclass: add ngx_force_module()

Peter Volkov <[email protected]>
Newsgroups gmane.linux.gentoo.devel
Message-ID <CAE+k_g+eeWMx0R3qztBbEiq-jwVFRjYPHVLMFa5eogwot7gc-w@mail.gmail.com>
On Tue, Aug 4, 2026 at 2:27 PM Sam James <[email protected]> wrote:
> Peter Volkov <[email protected]> writes:
> > On Sat, Jul 18, 2026 at 7:46 PM Zurab Kvachadze <[email protected]> wrote:
> >> +_ngx_mod_enforce_module_flags() {
> > ...
> >> +       # Check whether we already have the target_string or inverse_string in
> >> +       # the specified flag variable.
> >> +       local key
> >> +       for key in "${!ref_target[@]}"; do
> >> +               case "${ref_target[${key}]}" in
> >> +                       "${target_string}")
> >> +                               return 0
> >> +                               ;;
> >> +                       "${inverse_string}")
> >> +                               unset 'ref_target[${key}]'
> >> +                               return 0
> >> +                               ;;
> >
> > Maybe it would be a good idea to support --with-<mode>_module=dynamic
> > format as well. It's possible to provide such an option through
> > EXTRA_ECONF.
>
> Why would that be specified in EXTRA_ECONF?

Well, many years ago I used it with some nginx module, but... on
second thought, I agree. We don't need this at the moment.

I've uploaded changes here: https://codeberg.org/gentoo/gentoo/pulls/1621

--
Peter.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.