Re: [PATCH 09/10] nginx-module.eclass: add ngx_force_module()

Peter Volkov <[email protected]> writes:

> On Tue, Aug 4, 2026 at 2:27 PM Sam James <[email protected]> wrote:
>> Peter Volkov <[email protected]> writes:
>> > On Sat, Jul 18, 2026 at 7:46 PM Zurab Kvachadze <[email protected]> wrote:
>> >> +_ngx_mod_enforce_module_flags() {
>> > ...
>> >> +       # Check whether we already have the target_string or inverse_string in
>> >> +       # the specified flag variable.
>> >> +       local key
>> >> +       for key in "${!ref_target[@]}"; do
>> >> +               case "${ref_target[${key}]}" in
>> >> +                       "${target_string}")
>> >> +                               return 0
>> >> +                               ;;
>> >> +                       "${inverse_string}")
>> >> +                               unset 'ref_target[${key}]'
>> >> +                               return 0
>> >> +                               ;;
>> >
>> > Maybe it would be a good idea to support --with-<mode>_module=dynamic
>> > format as well. It's possible to provide such an option through
>> > EXTRA_ECONF.
>>
>> Why would that be specified in EXTRA_ECONF?
>
> Well, many years ago I used it with some nginx module, but... on
> second thought, I agree. We don't need this at the moment.

Right. And many years ago, we didn't have this eclass setup that allowed
external modules to be packaged properly ;)

>
> I've uploaded changes here: https://codeberg.org/gentoo/gentoo/pulls/1621

Thanks!

-----BEGIN PGP SIGNATURE-----

iQEBBAEWCgCpFiEEJaa7iN2bdkxrVUHCc4QJ9SDfkZAFAmpzQwAbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25z
Lm9wZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQyNUE2QkI4OEREOUI3NjRDNkI1NTQx
QzI3Mzg0MDlGNTIwREY5MTkwDxxzYW1AZ2VudG9vLm9yZwAKCRBzhAn1IN+RkJE1
AQCLGcJxWju1RHc8jGBUp4ZgaAmcH2GR3nzyXhQUZWlrjAEA+hZ2yVE6IqIn7AR4
luIfylOvUNJyqJh30/9mXbXtYAA=
=UtY5
-----END PGP SIGNATURE-----