die() required on pax-mark?
Michael Orlitzky <michael-h8kpsi0JglZWk0Htik3J/[email protected]>
| Newsgroups | gmane.linux.gentoo.hardened |
|---|---|
| Message-ID | <[email protected]> |
Due to my own stupidity (forgot to mount ext3 with -o user_xattr), I noticed that many ebuilds call pax-mark without a corresponding "|| die". Since pax-mark returns non-zero on failure, does not die itself, and is most likely required for the package to work, it seems like the 'die' should be there. Agreed? I could start filing bugs against the individual packages. The eclass docs are pretty clear to me, but maybe @hardened can add a note that 'die' is required on pax-mark? Or perhaps the function should die on its own? I believe the error message would be consistent; it might not make sense to add the same 'die' to every ebuild.