Re: die() required on pax-mark?
"Anthony G. Basile" <[email protected]>
| Newsgroups | gmane.linux.gentoo.hardened |
|---|---|
| Message-ID | <[email protected]> |
On 10/19/2013 02:20 PM, Michael Orlitzky wrote: > Due to my own stupidity (forgot to mount ext3 with -o user_xattr), I > noticed that many ebuilds call pax-mark without a corresponding "|| > die". Since pax-mark returns non-zero on failure, does not die itself, > and is most likely required for the package to work, it seems like the > 'die' should be there. > > Agreed? I could start filing bugs against the individual packages. The > eclass docs are pretty clear to me, but maybe @hardened can add a note > that 'die' is required on pax-mark? > > Or perhaps the function should die on its own? I believe the error > message would be consistent; it might not make sense to add the same > 'die' to every ebuild. > Can you check to see if the || die is required only on packages before EAPI = 5? Or is it on all EAPI versions? Having said that, I'm not sure we want the ebuild to fail just because pax-mark fails. People on vanilla profiles without xattr support will be annoyed. -- Anthony G. Basile, Ph. D. Chair of Information Technology D'Youville College Buffalo, NY 14201 (716) 829-8197